Re: [Linux-fbdev-devel] [PATCH] Free when fb can't be registered in video/aty/atyfb_base.c

[Roel K. <12...@ti...>]

Randy Dunlap wrote:
> 
> Use tabs for indent above, not spaces.
> 
> Yes, looks needed to me.  Hopefully Tony will correct us if we
> are wrong.
> 

Thanks for reviewing, here is one without the little spaces
--
Signed-off-by: Roel Kluin <12...@ti...>
--
diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
index d775eb6..669abd3 100644
--- a/drivers/video/aty/atyfb_base.c
+++ b/drivers/video/aty/atyfb_base.c
@@ -2680,10 +2680,13 @@ static int __devinit aty_init(struct fb_info *info)
 #endif /* CONFIG_FB_ATY_CT */
 	info->var = var;
 
-	fb_alloc_cmap(&info->cmap, 256, 0);
+	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0)
+		goto aty_init_exit;
 
-	if (register_framebuffer(info) < 0)
+	if (register_framebuffer(info) < 0) {
+		fb_dealloc_cmap(&info->cmap);
 		goto aty_init_exit;
+	}
 
 	fb_list = info;