[Linux-fbdev-devel] Re: [PATCH 3/5] au1100fb: Add power management support

[Andrew M. <ak...@os...>]

On Sun, 28 May 2006 08:42:37 +0800
"Antonino A. Daplas" <ad...@gm...> wrote:

> From: Rodolfo Giometti <gio...@li...>
> 
> Add power management support.
> 
>  int au1100fb_drv_suspend(struct device *dev, pm_message_t state)
>  {
> -	/* TODO */
> +	struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);
>  
>  int au1100fb_drv_resume(struct device *dev)
>  {
> -	/* TODO */
> +	struct au1100fb_device *fbdev = (struct au1100fb_device*) dev_get_drvdata(dev);

These typecasts of void* are unneeded.  They are in fact undesirable - if
someone were to change the type of dev_get_drvdata() to return some
non-pointer type then this code would still silently swallow it without
warning us of the bug.

Plus typecasts are ugly.


This patch doesn't apply, probably due to the earlier mangled one whihc I dropped.
Please redo and resend this one as well.