Re: [Linux-fbdev-devel] cursor maddnes and a solution

[James S. <jsi...@in...>]

> I don't have anything against hardware cursor support for userspace. And
> I don't even mind if we remove hardware cursor support for fbcon (I don't
> see the benefit anyway).  

Please don't remove hw cursor support from fbcon :-)

> struct fb_cursor_ops {
> 	int (*cursor_move)(int x, int y);
> 	int (*cursor_show)(int show);
> 	int (*cursor_load_image)(u32 *image, int width, int height);
> 	int (*cursor_load_color)(struct fb_cmap *cmap);
> 	int (*cursor_set_size)(int width, int height);
> 	int (*cursor_capabilities)(int set, int caps);
> };

> struct fb_info {
> 	...
> 	struct fb_cursor_ops *cursor_ops;
> 	...
> };

We don't need all that mess. You just have a struct fb_cursor in struct 
fb_info and fill in what data you want. All call fb_cusor when you want to 
alter the hardware state.