[Linux-fbdev-devel] [PATCH] skeletonfb

[Lucas C. V. R. <lu...@go...>]

Hi,

This patch just fixes some typos and adds retval documentation for some 
functions that were missing it.

I've also a question here: skeletonfb says that  xxxfb_setcolreg() should 
return a negative errno on error. However, if the register number being 
accessed is out of bounds, 1 is returned. Shouldn't it be better to return 
-EINVAL instead?  By looking at fbcmap.c, the retval isn't being checked 
against positive/negative values, so it doesn't make sense to return 1. 

Thanks,

-- 
Lucas
powered by /dev/dsp