Re: [Linux-fbdev-devel] Voyager GX color mapping

[Geert U. <ge...@li...>]

On Tue, 14 Dec 2004, Clemens Koller wrote:
> > > Well, whenever I change the (yet hardcoded) structs in the driver,
> > > fbset -fb /dev/fb2 shows me the correct (changed) values.
> > > But there is no change in X at all if I play around with the values.
> > > Is it possible that X doesn't get my fb_var_screeninfo? Maybe I need
> > > to check xorg.cfg again...
> > 
> > X may try to change the values again. If you're driver allows that (like it
> > seem to do, as per your description above), it may become confusion. Please
> > don't allow to change the bitfields in your driver, only allow the values
> > that
> > the hardware does support.
> 
> Okay... interesting... How does it (try and fail to) change it?
> Through IOCTL FBIOPUT_VSCREENINFO? Can I get more debug info out of it?

Yes, through FBIOPUT_VSCREENINFO. Your driver should refuse invalid values,
unless it can round them _up_ to make them valid.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds