From: Geert U. <ge...@li...> - 2004-11-22 09:43:42
|
On Mon, 22 Nov 2004, Antonino A. Daplas wrote: > On Sunday 21 November 2004 23:58, Adrian Bunk wrote: > > On Sun, Nov 21, 2004 at 04:37:02PM +0100, Adrian Bunk wrote: > > > The patch below does the following cleanups under drivers/video/ : > > > - make some needlessly global code static > > > - the following was needlessly EXPORT_SYMBOL'ed: > > > - fbcon.c: fb_con > > > - mdacon.c: fb_blank > > > - fbmon.c: get_EDID_from_firmware (completely unused) > > >... > > > > I forgot one thing: > > > > Please review my global_mode_option removal in modedb.c . > > > > It was always NULL and I'd say the only usage was wrong (although it > > had no practical effect). > > Should be ok to remove it. I only see fb_find_mode using it, and as > you've concluded, usage is not very clear. > > BTW: The global_mode_option, previously, is filled up when no driver is > specified in the boot options, such as "video=1024x768@60". But this was > removed during the fb initialization cleanup. What a pity... It allowed people to not have to care about the name of their graphics driver(s)... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li... In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds |