Re: [Linux-fbdev-devel] [PATCH] Fix leak in aty fb code. (fwd)

[Antonino A. D. <ad...@ho...>]

On Thursday 02 September 2004 17:44, Geert Uytterhoeven wrote:
> ---------- Forwarded message ----------
> Date: Wed, 1 Sep 2004 16:51:21 +0100
> From: Dave Jones <da...@re...>
> To: lin...@vg...
> Subject: [PATCH] Fix leak in aty fb code.
>
> Spotted with the source checker from Coverity.com.
>
> Signed-off-by: Dave Jones <da...@re...>
>
>
> diff -urpN --exclude-from=/home/davej/.exclude
> bk-linus/drivers/video/aty/atyfb_base.c
> linux-2.6/drivers/video/aty/atyfb_base.c ---
> bk-linus/drivers/video/aty/atyfb_base.c	2004-08-01 00:00:35.000000000 +0100
> +++ linux-2.6/drivers/video/aty/atyfb_base.c	2004-08-23 14:08:20.000000000
> +0100 @@ -2374,6 +2374,7 @@ int __init atyfb_init(void)
>  		}
>  	}
>  #endif				/* CONFIG_ATARI */
> +	kfree(info);
>  	return 0;
>  }
>

This is also incorrect, and will actually cause a crash. This is part of
init code, and info should not be freed.  It will be freed in
cleanup_module().

Tony