From: Benjamin H. <be...@ke...> - 2004-01-23 02:21:22
|
On Fri, 2004-01-23 at 12:22, Michel D=E4nzer wrote: > On Wed, 2004-01-21 at 00:09, random wrote:=20 > >=20 > > +void radeonfb_prim_fillrect(struct radeonfb_info *rinfo,=20 > > + const struct fb_fillrect *region) > > +{ > > + radeon_fifo_wait(4); =20 > > + =20 > > + OUTREG(DP_GUI_MASTER_CNTL, =20 > > + rinfo->dp_gui_master_cntl /* contains, like GMC_DST_32BPP */ > > + | GMC_BRUSH_SOLID_COLOR > > + | ROP3_P); > > + OUTREG(DP_BRUSH_FRGD_CLR, region->color); > > + OUTREG(DP_WRITE_MSK, 0xffffffff); >=20 > You could probably take this out of the acceleration functions, you > don't seem to need a different write mask? Yes, we could factor this one out > > + OUTREG(DP_CNTL, (DST_X_LEFT_TO_RIGHT | DST_Y_TOP_TO_BOTTOM)); > > + > > + radeon_fifo_wait(2); =20 > > + OUTREG(DST_Y_X, (region->dy << 16) | region->dx); > > + OUTREG(DST_WIDTH_HEIGHT, (region->width << 16) | region->height); > > + radeon_engine_idle (); >=20 > Why idle the engine in every acceleration function? Doesn't the API > provide a way to only do it when necessary? I don't do it in the patch I commited to my tree :) There is an fb_sync callback that you use for that. > PS: You lost my last reply to your private mails to your temporary > address scheme. And you'll lose mines too, please get rid of this shit and get a real address :) Ben. |