linux-fbdev-devel

Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Romain D. <do...@ir...>]

Michel D=E4nzer wrote:
>=20
> The attached patch significantly enhances the 16 bit handling of aty128=
fb.
> I've achieved this mainly by consequently distinguishing between 'depth=
' and
> 'bpp'. I've used these terms for the same meanings as in XFree86 4.x; p=
lease
> let me know if you prefer other terms.
>
> While this now works perfectly in X for both depth 15 and 16 as well as=
 in
> console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for
> fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the palett=
e for
> 565 should have 32 or 64 entries.

Hello,

Does the problem you mention occur when you switch directly
from RGBA 5551 to RGBA 5650 ? Does it also happen if you
switch to 32bpp RGB8888 or 8bpp CI8 in-between ?

I have a similar problem with pm3fb, if I change the RGBA
component but not the depth, colors are wrong, but changing
depth and back fix the problem. Maybe it's the same bug and
not directly related to the driver ?

--=20
DOLBEAU Romain               | l'histoire est entierement vraie, puisque
ENS Cachan / Ker Lann        |     je l'ai imaginee d'un bout a l'autre
do...@ir...             |           -- Boris Vian

Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Geert U. <ge...@li...>]

On Fri, 22 Jun 2001, Romain Dolbeau wrote:
> Michel D=E4nzer wrote:
> > The attached patch significantly enhances the 16 bit handling of aty1=
28fb.
> > I've achieved this mainly by consequently distinguishing between 'dep=
th' and
> > 'bpp'. I've used these terms for the same meanings as in XFree86 4.x;=
 please
> > let me know if you prefer other terms.
> >
> > While this now works perfectly in X for both depth 15 and 16 as well =
as in
> > console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for
> > fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the pale=
tte for
> > 565 should have 32 or 64 entries.
>=20
> Does the problem you mention occur when you switch directly
> from RGBA 5551 to RGBA 5650 ? Does it also happen if you
> switch to 32bpp RGB8888 or 8bpp CI8 in-between ?
>=20
> I have a similar problem with pm3fb, if I change the RGBA
> component but not the depth, colors are wrong, but changing
> depth and back fix the problem. Maybe it's the same bug and
> not directly related to the driver ?

Is this in the console?

If yes, the color map has to be updated when the depth is changed. Probab=
ly
fbgen (or pm3fb) tests for the bpp only.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org

In personal conversations with technical people, I call myself a hacker. =
But
when I'm talking to journalists I just say "programmer" or something like=
 that.
							    -- Linus Torvalds

Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Romain D. <do...@ir...>]

Geert Uytterhoeven wrote:

> Is this in the console?

Yes.

> If yes, the color map has to be updated when the depth is changed.
> Probably fbgen (or pm3fb) tests for the bpp only.

Yes, fbgen_set_var doesn't check for the RGBA component,
only bits_per_pixel, before changing cmap.

-- 
DOLBEAU Romain               | l'histoire est entierement vraie, puisque
ENS Cachan / Ker Lann        |     je l'ai imaginee d'un bout a l'autre
do...@ir...             |           -- Boris Vian

Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Michel <mic...@ii...>]

Romain Dolbeau wrote:
> 
> Michel Dänzer wrote:
> >
> > While this now works perfectly in X for both depth 15 and 16 as well as in
> > console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for
> > fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the palette
> > for 565 should have 32 or 64 entries.
> 
> Does the problem you mention occur when you switch directly
> from RGBA 5551 to RGBA 5650 ? Does it also happen if you
> switch to 32bpp RGB8888 or 8bpp CI8 in-between ?

It's the same no matter what I change to 5650 from.

> I have a similar problem with pm3fb, if I change the RGBA
> component but not the depth, colors are wrong, but changing
> depth and back fix the problem. Maybe it's the same bug and
> not directly related to the driver ?

Switching between 5550 and 5650, the colors are always right with the former
and wrong with the latter for me.


-- 
Earthling Michel Dänzer (MrCooper)    \   Debian GNU/Linux (powerpc) developer
CS student, Free Software enthusiast   \        XFree86 and DRI project member

Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Brad D. <br...@ne...>]

On 22 Jun 2001 02:16:54 +0200, Michel D=E4nzer wrote:
>=20
>=20
> The attached patch significantly enhances the 16 bit handling of aty128fb=
.
> I've achieved this mainly by consequently distinguishing between 'depth' =
and
> 'bpp'. I've used these terms for the same meanings as in XFree86 4.x; ple=
ase
> let me know if you prefer other terms.
>=20
> While this now works perfectly in X for both depth 15 and 16 as well as i=
n
> console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for
> fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the palette =
for
> 565 should have 32 or 64 entries.
>=20
>=20
> The patch is against 2.4.5-pre3 from Benjamin Herrenschmidt's tree so the
> offsets are probably off for Linus' tree.
>=20
>=20
> BTW I'd love to work on adding Rage128 and Radeon support to the new atyf=
b.
>=20
>=20
> PS: Ah yes, the patch also fixes panning. :)

Sorry guys.  I've tried to send that patch to Linus several times without i=
t
ever being accepted.  I should have been more consistently persistent.

PS -

My surgery ended up taking 8 hours, but it looks like things went better th=
an
expected and I'll probably never need a transplant!  Now just to recover...

Brad Douglas
br...@ne...

Re: [Linux-fbdev-devel] [PATCH] aty128fb 15/16 bit cleanup

[Michel <mic...@ii...>]

Brad Douglas wrote:
> 
> On 22 Jun 2001 02:16:54 +0200, Michel Dänzer wrote:
> >
> >
> > The attached patch significantly enhances the 16 bit handling of aty128fb.
> > I've achieved this mainly by consequently distinguishing between 'depth'
> > and 'bpp'. I've used these terms for the same meanings as in XFree86 4.x;
> > please let me know if you prefer other terms.
> >
> > While this now works perfectly in X for both depth 15 and 16 as well as in
> > console for fbset -depth 16 -rgba 5,5,5,0 , some colors are wrong for
> > fbset -depth 16 -rgba 5,6,5,0 . It's not clear to me whether the palette
> > for 565 should have 32 or 64 entries.
> >
> >
> > The patch is against 2.4.5-pre3 from Benjamin Herrenschmidt's tree so the
> > offsets are probably off for Linus' tree.
> >
> >
> > BTW I'd love to work on adding Rage128 and Radeon support to the new
> > atyfb.
> >
> >
> > PS: Ah yes, the patch also fixes panning. :)
> 
> Sorry guys.  I've tried to send that patch to Linus several times without it
> ever being accepted.  I should have been more consistently persistent.

No problem, previous versions of the patch weren't as good as I would have
liked anyway. And Ani is merging it into his tree now.


> My surgery ended up taking 8 hours, but it looks like things went better
> than expected and I'll probably never need a transplant!  Now just to
> recover...

Unfortunately, I don't know what this is about, but I'm sure glad it went
fine, all the best!


-- 
Earthling Michel Dänzer (MrCooper)    \   Debian GNU/Linux (powerpc) developer
CS student, Free Software enthusiast   \        XFree86 and DRI project member