From: Miquel v. S. <mi...@ci...> - 2003-02-25 21:02:00
|
According to Michael D Labriola: > According to myself: >> >> # br2684ctl -c 10 -a 10.1.1 >> RFC1483/2684 bridge: Interface "nas10" created succesfully >> RFC1483/2684 bridge: Communicating over ATM 10.1.1, encapsulation: LLC >> RFC1483/2684 bridge: Fatal: failed to connect on socket >> >> # ifconfig nas10 192.168.10.10 >> >> <kernel panic> > hmm... i think i just posted a related issue... > i might be running into a NULL skb inside clip_start_xmit()... > i wonder if these two problems are both caused by the same thing Found it. > It looks like something has corrupted an skb, and the > next try to allocate an skb panics: It did. Turns out that the .._start_xmit functions must NOT free the skb when returning an error, in that case the caller frees the skb. When returning success, the .._start_xmit function is responsible for freeing the skb. So br2684_start_xmit needs to either dev_free_skb() or return an error, but not both. I've changed it to dev_free_skb() and return success, because otherwise the packet in the output queue keeps on being requeued and that makes the load a steady 1.00. Now on to find the rest of the problems .. patches will be forthcoming, ofcourse. Mike. -- Anyone who is capable of getting themselves made President should on no account be allowed to do the job -- Douglas Adams. |