Re: [Linux-ATM-General] Re: [PATCH] Updated ATM patch for 2.4.19-pre4

[Maksim K. <ma...@qu...>]

>Comments welcome.
Looks ok to me.

>  static inline struct br2684_dev *BRPRIV(const struct net_device *net_dev)
>  {
>-       return (struct br2684_dev *) ((char *) (net_dev) -
>-           (unsigned long) (&((struct br2684_dev *) 0)->net_dev));
>+       return list_entry(net_dev, struct br2684_dev, net_dev);
>  }
Although list_entry does the same thing it's inappropriate here. People 
will be confused.

Max