From: Pascal H. <pa...@pl...> - 2011-07-29 22:52:53
|
Karl Hiramoto a écrit : > On 7/29/2011 12:30 PM, chas williams - CONTRACTOR wrote: >> On Thu, 28 Jul 2011 21:10:38 +0200 >> Francois Romieu<ro...@fr...> wrote: >> >>> A short explanation of the skb_pull(skb, ETH_HLEN) for e_vc/p_routed in >>> br2684_xmit_vcc would be welcome. >>> >>> I do not see how there can be ETH_HLEN excess bytes in this direction. >>> >> yeah, i think this skb_pull() is wrong. when a routed interface is >> setup, it shouldnt be prepending ethernet headers on the outgoing >> packets so there shouldnt be any need to remove an ethernet header. >> >> anyone willing/capable of testing a patch? > > FWIW I tested br2684 with a ADSL DSLAM I have access to, in routed > mode about a year ago with 2.6.32 and all worked fine. Was the encapsulation method LLC or VC-MUX ? |