From: Roman Z. <zi...@li...> - 2005-08-01 19:09:15
|
Hi, On Mon, 1 Aug 2005, John W. Linville wrote: > Actually, the warnings were specifically with the arguments in the > write routines. My compiler actually produced errors here, but I fixed differently here. Anyway, please hold off with patches for a few days, some of these thing are already fixed in my tree and I want to test them first before I commit them. > I noticed that "__asm__ __volatile__" seems to be > the more common usage , so I just changed it for consistency in all > the routines. Is this problematic? > > Is there a meaningful difference between the two? There is only a difference if you want to compile the source with the -ansi switch, which is pointless for the kernel and what makes them redundant, so I prefer them without underscores. bye, Roman |