Re: chipram bug?

[Roman Z. <zi...@li...>]

Hi,

Geert Uytterhoeven wrote:

> When looking at arch/m68k/amiga/chipram.c:amiga_chip_init(), there seem to be
> at least 2 problems:
> 
> | void __init amiga_chip_init(void)
> | {
> |     if (!AMIGAHW_PRESENT(CHIP_RAM))
> |         return;
> | 
> | #ifndef CONFIG_APUS_FAST_EXCEPT
>   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Woops, this is done on m68k as well! Is this condition correct?
> Either we should at a test for PPC, or perhaps this was a typo and it should it
> be `#ifdef' instead of `#ifndef'?

This can actually be removed, CONFIG_APUS_FAST_EXCEPT is always defined 
now for APUS.

> |     /*
> |      *  Remove the first 4 pages where PPC exception handlers will be located
>                  ^^^^^^^^^^^^^^^^^
> |      */
> |     amiga_chip_size -= 0x4000;
> 
> Shouldn't this be
> 
>     chipram_res.start += 0x4000;
> 
> ?

The chipram start was modified in asm-ppc/amigahw.h.

bye, Roman