chipram bug?

[Geert U. <ge...@li...>]

When looking at arch/m68k/amiga/chipram.c:amiga_chip_init(), there seem to be
at least 2 problems:

| void __init amiga_chip_init(void)
| {
|     if (!AMIGAHW_PRESENT(CHIP_RAM))
|         return;
| 
| #ifndef CONFIG_APUS_FAST_EXCEPT
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Woops, this is done on m68k as well! Is this condition correct?
Either we should at a test for PPC, or perhaps this was a typo and it should it
be `#ifdef' instead of `#ifndef'?

|     /*
|      *  Remove the first 4 pages where PPC exception handlers will be located
                 ^^^^^^^^^^^^^^^^^
|      */
|     amiga_chip_size -= 0x4000;

Shouldn't this be

    chipram_res.start += 0x4000;

?

| #endif
|     chipram_res.end = amiga_chip_size-1;
|     request_resource(&iomem_resource, &chipram_res);
| 
|     chipavail = amiga_chip_size;
| }

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds