Re: Kernel 2.4.21

[Marek S. <ma...@st...>]

Hello a.l...@lb...

On 05.08.03, you wrote:

> Hi,

>> Have you tried to replace both apne.c and 8390.h with the files from
>> 2.4.18 source tree?

> we cant do that as there are other drivers which use the new 8390
> driver....as well as needing to keep changes in the tree.

But the only difference between 'old' 8390.h and 'new' 8390.h are the lines
that enable custom register set for 8390 driver, when used by the apne
driver... You can apply included patch on 8390.h and then use old apne.c
driver without any problems.

> having a look at this a couple of thigns jump out....
> 1) at the end of 8390.c i see
> out_8(GAYLE_ATTRIBUTE+offset, config);
> should this not be 
> outb(config, GAYLE_ATTRIBUTE+offset);
> ?

NO. This is 'special' case. The Gayle registers are needed to be changed,
not Gayle-PCMCIA registers (new inb and friends are only for Gayle-PCMCIA
registers).

> 2) the if defined(CONFIG_AMIGA_PCMCIA) part has been removed...
> which means that the APUS system doesnt get told about the new 
> inb/outb rules (the following 10 lines the starty with #undef inb
> and end with #define outb_p.....
> ..this means that the apne.c code isnt going to be happy at all.

True.

> perhaps whoever hit the 8390 code didnt account for this...and
> we should have a configure line put back in so that these defines
> are used?

We need to decide what we want. 

Adding proper Amiga-PCMCIA-ISA io code is much harder in APUS, because inb
and friends *ARE* used in other places (asm/dma.h, drivers/char/mem.c, IDE
driver, maybe others - I haven't got enough motivation/time to trace this).
The easies way to fix all that mess with 'new' apne driver is to apply this
patch on 8390.h, use 'old' apne driver and remove all my PCMCIA-ISA stuff.
I know that doing this we will be incompatible with m68k tree, but keeping
'new' version would require to change other drivers, so incompatibility
would remain. I don't know how these problems are being handled in m68k
tree, especially IDE driver and char/mem.c, which uses inb() and friends.

Any comments? Please say something. 

Regards
PS. In 2 days I'm going for hollidays for about month. I spent a few night
looking for changes in code after 2.4.18, but till now haven't found why
dmasound doesn't work.
-- 
Marek Szyprowski .. GG:2309080 .. mailto:ma...@am... ..
...... happy AmigaOS, MacOS and Debian/Linux user ........
........... http://march.home.staszic.waw.pl/ ............