Re: Amiga SFS file system Linux driver

[Marek S. <ma...@st...>]

Hello Roman

I'm also sorry for the delay, but I had an unplaned hollidays...

On 28.06.03, you wrote:

>> > - wrap the access to asfs_inode_info/asfs_sb_info into macros, this
>> > will make it easier to port to 2.5/6.
> Yes, in 2.5 you'll find this in pretty much every driver.

Done.

> I had the time now to play a little with and you need to add the
> sync_page function to asfs_aops, otherwise the I/O is started rather
> randomly.

Thanks. It was probably due to my lack of knowledge about linux file
systems...

> It makes further development simpler, at some point you have to remove
> it anyway. First, it makes reading the source easier, if one knows which
> structures are on disk and which are in memory and each should be in its
> native order. Right now you don't cache any data, but as soon as you do
> that, you will need separate structures to cache disk data. It becomes
> even more important, if you want to add write support.

I'll remove it when the support for hash tables will be added (this should
really speed-up directiories reading). But now I'm waiting for a sample
code from SFS team, showing how to use these hash tables...

> I'll commit a version with a few small fixes. Here a few more things I
> noticed while going over the driver:
> - You should read the inode via the read_inode2 function (use iget4 and
> you can pass it the fsObject), this avoids creating inodes with
> duplicate inode numbers.

Done.

> - asfs_search_BNodeTree shouldn't return structures, use a pointer and
> return a proper error value instead.

Done.

> - if asfs is case-insensitive, you'll probably want to add
> dentry_operations similiar to affs.

As I noticed it is only important for read/write filesystems.

> - please make the lines shorter, they don't have to be exactly 80
> characters, but it's a good goal.

I will try, but it hard to keep lines so short on console, which is almost
two times larger... 



On 28.06.03, you wrote:

>> My sf.net id is march123, but if you could, please commit my changes. 
> I added you as a developer, as Michel mentioned you only need to checkout 
> the files you need.

I commited my changes. I hope I've made every thing in a proper way.

Regards
-- 
Marek Szyprowski .. GG:2309080 .. mailto:ma...@am... ..
...... happy AmigaOS, MacOS and Debian/Linux user ........
........... http://march.home.staszic.waw.pl/ ............