Re: Amiga SFS file system Linux driver

[Marek S. <ma...@st...>]

Hello Roman

On 15.06.03, you wrote:

> Nice work. :-)

Thanks ;)

> I only have some minor comments:
> - could you get rid of the LONG/WORD/.. typedefs and replace them with
> s32/s16?

Done

> - wrap the access to asfs_inode_info/asfs_sb_info into macros, this will
> make it easier to port to 2.5/6.

Same as in for example AFFS driver?

> - could you place the braces according to the coding style?

Done, altough the previous version was more leggible for me...

> - you likely want to implement a get_block function like other file
> systems do instead of implementing the readpage function.

I implemented this, but... The new version is terribly slow! Kernel waits
few second before it reads almost every single block! I don't know where is
the problem. My routines are simmilar to the routines used in other file
systems (I based on AFFS driver). I thinks that I forgot to set-up
something, but I don't know what. Could you help me finding the bug?

> - it's probably also better to avoid the from32be/from16be macros and
> convert the values as needed.

Is it really the problem? I decided to correct all values in reading
functions, so the other functions do not need to care wheather the values
are in big or little endian...

Regards
-- 
Marek Szyprowski .. GG:2309080 .. mailto:ma...@am... ..
...... happy AmigaOS, MacOS and Debian/Linux user ........
........... http://march.home.staszic.waw.pl/ ............