Re: Amiga SFS file system Linux driver

[Roman Z. <zi...@li...>]

Hi,

Marek Szyprowski wrote:

> This this is the second version of my linux Amiga Smart File System driver.
> I've fixed some bugs, cleaned up the code and added some features.
> 
> On http://march.home.staszic.waw.pl/asfs/ there is a sample image of
> AmigaSFS disk for testing, patch against the previous version and a compiled
> module for 2.4.18 kernel (put it in "/lib/modules/2.4.18/kernel/fs/asfs/").
> 
> Now its almost full-featured, working read-only driver. :)

Nice work. :-)
I only have some minor comments:
- could you get rid of the LONG/WORD/.. typedefs and replace them with
s32/s16?
- wrap the access to asfs_inode_info/asfs_sb_info into macros, this will
make it easier to port to 2.5/6.
- could you place the braces according to the coding style?
- you likely want to implement a get_block function like other file
systems do instead of implementing the readpage function.
- it's probably also better to avoid the from32be/from16be macros and
convert the values as needed.

bye, Roman