A late night idea about debian bf's and the "Install Operating System Modules" lines

[Andreas <an...@po...>]

Hi

I have been browsing a bit trough the debian boot-floppy cvs (out of pure interest), and then
I had the idea to look after the code related to the options menu, having in
mind the enervating "Install Operating System Modules" lines. Wouldn't it be
possible to apply a fix like the following to get rid of them (only if they really
aren't needed, of course!)?

And to say it straight: sorry about my bad c form, but I am not a c coder..

(the file is:
http://cvs.debian.org/boot-floppies/utilities/dbootstrap/main_menu.c )

#if (#cpu(powerpc))

+ if (strcmp(Arch2, "apus") != 0) {
        struct { char *string; int key; } entries_apus[] = {
> btw: why is it referring to            ^^^^^^^^^^^^^  apus here ?

                {_("Configure the Keyboard"),                           OPT_CONFIGURE_KEY},
                {_("Partition a Hard Disk"),                            OPT_PARTITION_DISK},
                {_("Initialize and Activate a Swap Partition"),         OPT_INITIALIZE_SWAP},
                {_("Activate a Previously-Initialized Swap Partition"), OPT_ACTIVATE_SWAP},
                {_("Do Without a Swap Partition"),                      OPT_DO_WITHOUT_SWAP},
                {_("Initialize a Linux Partition"),                     OPT_INITIALIZE_LINUX},
                {_("Mount a Previously-Initialized Partition"),         OPT_MOUNT_LINUX},
                {_("Unmount a Partition"),                              OPT_UMOUNT_LINUX},
                {_("Install Operating System Modules"),                 OPT_INSTALL_OS},
                {_("Configure Device Driver Modules"),                  OPT_CONFIGURE_MODULES},
                {_("Install Foreign Modules"),                          OPT_FOREIGN_MODULES},
                {_("Configure the Hostname"),                           OPT_CONFIGURE_HOSTNAME},
                {_("Configure the Network"),                            OPT_CONFIGURE_NET},
                {_("Install the Base System"),                          OPT_INSTALL_BASE},
                {_("Reboot the System"),                                OPT_REBOOT},
                {_("View the Partition Table"),                         OPT_VIEW_PARTITIONS},
                {_("Execute a Shell"),                                  OPT_EXECUTE_SHELL},
                {_("Restart Installation System"),                      OPT_RESTART_DBOOTSTRAP},
                {_("Report a Problem"),                                 OPT_PROBLEM_REPORT},
                {NULL,0}
        };
+ }
+ else {
+        struct { char *string; int key; } entries_apus[] = {
+                {_("Configure the Keyboard"),                           OPT_CONFIGURE_KEY},
+                {_("Partition a Hard Disk"),                            OPT_PARTITION_DISK},
+                {_("Initialize and Activate a Swap Partition"),         OPT_INITIALIZE_SWAP},
+                {_("Activate a Previously-Initialized Swap Partition"), OPT_ACTIVATE_SWAP},
+                {_("Do Without a Swap Partition"),                      OPT_DO_WITHOUT_SWAP},
+                {_("Initialize a Linux Partition"),                     OPT_INITIALIZE_LINUX},
+                {_("Mount a Previously-Initialized Partition"),         OPT_MOUNT_LINUX},
+                {_("Unmount a Partition"),                              OPT_UMOUNT_LINUX},
+                {_("Configure the Hostname"),                           OPT_CONFIGURE_HOSTNAME},
+                {_("Configure the Network"),                            OPT_CONFIGURE_NET},
+                {_("Install the Base System"),                          OPT_INSTALL_BASE},
+                {_("Reboot the System"),                                OPT_REBOOT},
+                {_("View the Partition Table"),                         OPT_VIEW_PARTITIONS},
+                {_("Execute a Shell"),                                  OPT_EXECUTE_SHELL},
+                {_("Restart Installation System"),                      OPT_RESTART_DBOOTSTRAP},
+                {_("Report a Problem"),                                 OPT_PROBLEM_REPORT},
+                {NULL,0}
+        };
+ }
#endif

And btw, couldn't this be solved by an #if definition?

Well, of course there have to be made some other adjustements in the code
below this paragraph, I am especially thinking about the 'bufA=' and so on lines.

-- 
A good idea, or should I better close my mouth now?
Andi