Re: CVS Update: 2.3 (branch: trunk)

[Geert U. <ge...@li...>]

On Mon, 5 Nov 2001, Roman Zippel wrote:
> On Mon, 5 Nov 2001, Geert Uytterhoeven wrote:
> > >   1.4           +89 -55    2.3/drivers/ide/ide-probe.c
> > >   1.4           +283 -171  2.3/drivers/ide/ide.c
> >
> > Since I was interested in seeing this fix, I diffed both files (against 1.3),
> > but it looks like lots of other things were changed, too. Is that correct?
>
> No, the number of changes are against the wrong file (1.3 is from
> 2.4.0-test2, also see the log), you want these diffs:

IC.

> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/linux-apus/2.3/drivers/ide/ide.c.diff?r1=text&tr1=1.1.1.16&r2=text&tr2=1.4&diff_format=h
> http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/linux-apus/2.3/drivers/ide/ide-probe.c.diff?r1=text&tr1=1.1.1.10&r2=text&tr2=1.4&diff_format=h
>
> The problem is that request_irq is between disable_irq/enable_irq and the
> ppc version of enable_irq doesn't like this, because request_irq resets
> the counter.

OK. But we still disable the IRQ during probing, right?

I still remember the hard hacking that lead to that change: some Western
Digital Caviar drives didn't honour the ATA disable IRQ bit, so they caused an
interrupt deadlock if you probed for them on Amiga with the IDE interrupt
enabled. The problem didn't show up on PC because they had no shared
interrupts, while on A4000 the IDE interrupt is shared with Zorro Ethernet,
which was still enabled.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds