Re: cyberfb prob. (was: newbie needs help with modules)

[Geert U. <ge...@li...>]

On Thu, 3 Aug 2000, Glenn Hisdal wrote:
> > On Wed, 2 Aug 2000, Glenn Hisdal wrote:
> >> On 02-Aug-2000, you wrote:
> >>>> I still can't get the cybervision64 driver to work in 2.4 though (It
> >>>> compiles fine, but I can't use it).
> >>>> The kernel just uses amifb:vga even if i tell it to use cyberfb...
> >> 
> >>> Looking at drivers/video/fbmem.c, you should try video=cyber:...
> >> 
> >> Yes, that's what I use... (video=cyber:800x600-8)
> >> won't work. Guess I'll have to stick with 2.2.10 a litte longer.
> 
> > Please #define CYBERFBDEBUG in drivers/video/cyberfb.c and tell us more.
> 
> done.
> Here's the dmesg output :

    [...]

> cyberfb_init: ENTER

And nothing more. So it fails in the resource management code.

Ah, stupid typo. The CV64 has 4 MB RAM, not 64... I also missed the release in
case of an error. Does the patch below help?

Just wondering why no one ever noticed this ;-)

--- linux-2.4.0-test6-pre1/drivers/video/cyberfb.c.orig	Fri Jul 28 21:19:18 2000
+++ linux-2.4.0-test6-pre1/drivers/video/cyberfb.c	Thu Aug  3 14:24:20 2000
@@ -1066,7 +1066,7 @@
 	    CyberRegs_phys = CyberMem_phys + 0x00c00000;
 	    if (!request_mem_region(CyberRegs_phys, 0x10000, "S3 Trio64"))
 		continue;
-	    if (!request_mem_region(CyberMem_phys, 0x4000000, "RAM")) {
+	    if (!request_mem_region(CyberMem_phys, 0x400000, "RAM")) {
 		release_mem_region(CyberRegs_phys, 0x10000);
 		continue;
 	    }
@@ -1110,7 +1110,8 @@
 
 	    if (register_framebuffer(&fb_info) < 0) {
 		    DPRINTK("EXIT - register_framebuffer failed\n");
-		    release_mem_region(board_addr, board_size);
+		    release_mem_region(CyberMem_phys, 0x400000);
+		    release_mem_region(CyberRegs_phys, 0x10000);
 		    return -EINVAL;
 	    }
 

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@li...

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds