linux-apus-devel

Sound (again)

[Ken T. <ke...@we...>]

Sorry, a bit quick on the go button there!

Any success with recent patches to 2.4.3 sound ?

Won't compile here.

gcc (etc) dmasound_core.o
dmasound_core.c
dmasound_core.c: In function `sq_init':
dmasound_core.c:1264: warning: unused variable `res'

dmasound_core.c: In function `dmasound_setup':
dmasound_core.c:1625: invalid operands to binary <<

         size = ints << 10 

Which is a shift of an array name.

Ken.

Re: Sound (again)

[Michel <mic...@ii...>]

Ken Tyler wrote:
> 
> Sorry, a bit quick on the go button there!

It happens to all of us. :)


> Any success with recent patches to 2.4.3 sound ?
> 
> Won't compile here.
> 
> gcc (etc) dmasound_core.o
> dmasound_core.c
> dmasound_core.c: In function `sq_init':
> dmasound_core.c:1264: warning: unused variable `res'
> 
> dmasound_core.c: In function `dmasound_setup':
> dmasound_core.c:1625: invalid operands to binary <<
> 
>          size = ints << 10
> 
> Which is a shift of an array name.

That code is only used when the driver is built into the kernel, that's how it
crept in.

The fix I just committed builds, let's hope it also makes sense. ;)


-- 
Earthling Michel Dänzer (MrCooper)    \   Debian GNU/Linux (powerpc) developer
CS student, Free Software enthusiast   \        XFree86 and DRI project member

Re: Sound (again)

[Geert U. <ge...@li...>]

On Thu, 26 Apr 2001, Michel D=E4nzer wrote:
> Ken Tyler wrote:
> > Sorry, a bit quick on the go button there!
>=20
> It happens to all of us. :)
>=20
> > Any success with recent patches to 2.4.3 sound ?
> >=20
> > Won't compile here.
> >=20
> > gcc (etc) dmasound_core.o
> > dmasound_core.c
> > dmasound_core.c: In function `sq_init':
> > dmasound_core.c:1264: warning: unused variable `res'
> >=20
> > dmasound_core.c: In function `dmasound_setup':
> > dmasound_core.c:1625: invalid operands to binary <<
> >=20
> >          size =3D ints << 10
> >=20
> > Which is a shift of an array name.
>=20
> That code is only used when the driver is built into the kernel, that's=
 how it
> crept in.
>=20
> The fix I just committed builds, let's hope it also makes sense. ;)

I don't have the APUS tree at hand, but I don't see anything like that in=
 the
bk tree nor in Linus' tree, nor in the m68k tree.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m6=
8k.org

In personal conversations with technical people, I call myself a hacker. =
But
when I'm talking to journalists I just say "programmer" or something like=
 that.
							    -- Linus Torvalds

Re: Sound (again)

[Michel <mic...@ii...>]

Geert Uytterhoeven wrote:
>=20
> On Thu, 26 Apr 2001, Michel D=E4nzer wrote:
> > Ken Tyler wrote:
> > > gcc (etc) dmasound_core.o
> > > dmasound_core.c
> > > dmasound_core.c: In function `sq_init':
> > > dmasound_core.c:1264: warning: unused variable `res'
> > >
> > > dmasound_core.c: In function `dmasound_setup':
> > > dmasound_core.c:1625: invalid operands to binary <<
> > >
> > >          size =3D ints << 10
> > >
> > > Which is a shift of an array name.
> >
> > That code is only used when the driver is built into the kernel, that=
's
> > how it crept in.
> >
> > The fix I just committed builds, let's hope it also makes sense. ;)
>=20
> I don't have the APUS tree at hand, but I don't see anything like that =
in
> the bk tree nor in Linus' tree, nor in the m68k tree.

Roman integrated some of Iain Sandoe's code to fix the oopsen people repo=
rted.


--=20
Earthling Michel D=E4nzer (MrCooper)    \   Debian GNU/Linux (powerpc) de=
veloper
CS student, Free Software enthusiast   \        XFree86 and DRI project m=
ember

Re: Sound (again)

[Ken T. <ke...@we...>]

On Thu, 26 Apr 2001, Michel D=E4nzer wrote:

> That code is only used when the driver is built into the kernel, that's h=
ow it
> crept in.

> The fix I just committed builds, let's hope it also makes sense. ;)

Works fine in a monolithic kernel but not as a module.  Won't load on
demand and insmod on dmasound_core and dmasound_paula gives many
unresolved symbols.

Ken.

Re: Sound (again)

[Michel <mic...@ii...>]

Ken Tyler schrieb:
>=20
> On Thu, 26 Apr 2001, Michel D=E4nzer wrote:
>=20
> > That code is only used when the driver is built into the kernel, that=
's
> > how it crept in.
>=20
> > The fix I just committed builds, let's hope it also makes sense. ;)
>=20
> Works fine in a monolithic kernel but not as a module.  Won't load on
> demand and insmod on dmasound_core and dmasound_paula gives many
> unresolved symbols.

But that can't be due to my commit can it? AFAICS I only changed code for=
 the
monolithic case.


--=20
Earthling Michel D=E4nzer (MrCooper)    \   Debian GNU/Linux (powerpc) de=
veloper
CS student, Free Software enthusiast   \        XFree86 and DRI project m=
ember