[Linpha-cvs] SF.net SVN: linpha: [4556] trunk/linpha2

[<fan...@us...>]

Revision: 4556
Author:   fangehrn
Date:     2006-07-16 09:29:17 -0700 (Sun, 16 Jul 2006)
ViewCVS:  http://svn.sourceforge.net/linpha/?rev=4556&view=rev

Log Message:
-----------
updated docu

Modified Paths:
--------------
    trunk/linpha2/get_image.php
    trunk/linpha2/get_thumb.php
    trunk/linpha2/lib/classes/linpha.image.class.php
    trunk/linpha2/linpha2.specs.txt

Added Paths:
-----------
    trunk/linpha2/docs/dev/important stuff.txt
Added: trunk/linpha2/docs/dev/important stuff.txt
===================================================================
--- trunk/linpha2/docs/dev/important stuff.txt	                        (rev 0)
+++ trunk/linpha2/docs/dev/important stuff.txt	2006-07-16 16:29:17 UTC (rev 4556)
@@ -0,0 +1,15 @@
+- if we use exec($str, $array_output=array(), $return_value='');
+	it will always return empty $array_output and $return_value
+
+	you have to initialize $array_output and $return_value before!
+
+	$array_output = array(); $return_value = '';
+	exec($str, $array_output, $return_value);
+
+
+
+- filesize($tmp_file) may return zero if clearstatcache() is not executed!
+
+          clearstatcache();
+          $handle = fopen($tmp_file, "rb");
+          $file_data = fread($handle, filesize($tmp_file));
\ No newline at end of file

Modified: trunk/linpha2/get_image.php
===================================================================
--- trunk/linpha2/get_image.php	2006-07-15 17:01:25 UTC (rev 4555)
+++ trunk/linpha2/get_image.php	2006-07-16 16:29:17 UTC (rev 4556)
@@ -50,7 +50,7 @@
 	$linpha->sql->startSession();
 	
 	$image = new LinImage();
-	if( ! $image->createImage($_GET['id'],$overrideSettings) )
+	if( ! $image->createImage($_GET['id'],$overrideSettings) )	// returns false if no permission
 	{
 		throw new Exception("Error while creating image!<br />Error: ".$image->error_msg);
 	}

Modified: trunk/linpha2/get_thumb.php
===================================================================
--- trunk/linpha2/get_thumb.php	2006-07-15 17:01:25 UTC (rev 4555)
+++ trunk/linpha2/get_thumb.php	2006-07-16 16:29:17 UTC (rev 4556)
@@ -40,7 +40,7 @@
 	$linpha->sql->startSession();
 	
 	$thumbnail = new LinImage();
-	if( ! $thumbnail->createThumbnail($_GET['id']) )
+	if( ! $thumbnail->createThumbnail($_GET['id']) )	// returns false if no permission
 	{
 		throw new Exception("Error while creating thumbnail!<br />Error: ".$thumbnail->error_msg);
 	}

Modified: trunk/linpha2/lib/classes/linpha.image.class.php
===================================================================
--- trunk/linpha2/lib/classes/linpha.image.class.php	2006-07-15 17:01:25 UTC (rev 4555)
+++ trunk/linpha2/lib/classes/linpha.image.class.php	2006-07-16 16:29:17 UTC (rev 4556)
@@ -279,6 +279,8 @@
 
 /**
  * thumbnail functions
+ * 
+ * @return  true on success, false on failure (checks for valid id, valid image, valid permission!)
  */
 	function createThumbnail($photo_id)
 	{

Modified: trunk/linpha2/linpha2.specs.txt
===================================================================
--- trunk/linpha2/linpha2.specs.txt	2006-07-15 17:01:25 UTC (rev 4555)
+++ trunk/linpha2/linpha2.specs.txt	2006-07-16 16:29:17 UTC (rev 4556)
@@ -54,10 +54,10 @@
 	   - smart_htmlspecialchars() from phpmeta used several times in forms in linpha1
 	   ?
   - ?
-- users have to use firefox
-  will hang me up on adapting css to internet explorer
-  (who finds sarcasm may keep it..)
-  ;-)
+- php session
+  limit the session cookie not only to domain, but also to full url path
+  we cannot use the same session in localhost/linpha1.0 and localhost/linpha2.0
+  -> session_set_cookie_params()
   
 Part 4: External Libs
 ==============================================================================


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.