Menu

#252 view all exif doesn't work in 1.3.4

next release
open-fixed
bzrudi
engine (135)
5
2008-07-20
2008-07-19
No

There is a bug in include/metadata_editor.php

The problem is right in the beginning of the file:

================

unset($filename);

/**
* security
*/
if(!isset($filename) || strlen($_GET['md5sum']) <> 32)
{
exit();
================

First you unset $filename and than if filename is not set (which it isn't) you exit.

I have removed the ! from infront of the isset and than it works again but I find it odd that you unset something and than one instruction later you check that it has been unset. I would remove the entire isset from the if.

Cheers,
Bastiaan

Discussion

  • bzrudi

    bzrudi - 2008-07-20
    • labels: --> engine
    • milestone: --> next release
    • assigned_to: nobody --> bzrudi
    • status: open --> open-fixed
     
  • bzrudi

    bzrudi - 2008-07-20

    Logged In: YES
    user_id=184593
    Originator: NO

    Hi Bastiaan,

    fixed in CVS, next release will include it.
    Thanks!

    cheers bzrudi

     

Log in to post a comment.