Re: [Plog-general] Re: New class "adminlistvalues"

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Hi!

I just committed your changes to CVS. And did not find any bug... What did you 
mean that there was a bug? There is no need to worry about selected indexes 
or anything... Our php script will get the value of the selected item of the 
drop-down list. As easy as it sounds ;), as long as we set the right value in 
the drop-down list, there won't be no problem.

For the time being we'll leave the structure of the table as it is but it will 
probably be improved in the future so that we can use for other things... I 
will also modify the wizard.php script so that it also creates and fills that 
table with some default values.

Finally, have a look when you have the time to the CVS. I've made a few 
changes to the script, little things that probably you didn't know but I did 
;) There you go:

- Whenever you need to access the database, extend the Model class. Its 
constructor automatically connects and you'll have $this->_db as the data 
access object. No need to manually do it :)

- Personally -and I guess it's just a matter of taste but I like it- I name 
the functions starting with the '_' character when they are private. PHP does 
not offer support for private methods but that helps to notice if I should be 
using it or not ;)

- Finally, if you have any problem "reading" the code, use Doxygen. Don't know 
if you have heard of it, but it automatically generates documentation from 
code and comments, kind of what javadoc does. I have documentetd every class 
and almost every function with that, so I would encourage you to do the same 
also. 

I hope you don't think I'm getting too grumpy. I am just trying to keep some 
consistency between everybody's code :) I really appreciate your help and if 
you think it necessary, you could even be given CVS commit access...

Regards,

Oscar.

On Wednesday 30 July 2003 20:57, Bradley Liang wrote:
> My mistake, I created a bug here... in adminupdateblogsettings.class.php
>
> how would you get around needing
> blogLocale.selectedIndex.value() ?
>
> The error arrises because getValue(blogLocale) will terminate the request
> object with a null response.  getValue (blogLocale.selectedIndex) is what
> should be taken, but this is not the case.
>
> Help?
>
> At 08:22 PM 7/29/2003 -0700, you wrote:
> >Send Plog-general mailing list submissions to
> >         plo...@li...
> >
> >To subscribe or unsubscribe via the World Wide Web, visit
> >         https://lists.sourceforge.net/lists/listinfo/plog-general
> >or, via email, send a message with subject or body 'help' to
> >         plo...@li...
> >
> >You can reach the person managing the list at
> >         plo...@li...
> >
> >When replying, please edit your Subject line so it is more specific
> >than "Re: Contents of Plog-general digest..."
> >
> >
> >Today's Topics:
> >
> >    1. New class "adminlistvalues" (Bradley Liang)
> >
> >--__--__--
> >
> >Message: 1
> >Date: Tue, 29 Jul 2003 20:17:01 -0400
> >To: plo...@li...
>
> From: Bradley Liang <bl...@bl...>
>
> >Subject: [Plog-general] New class "adminlistvalues"
> >Reply-To: plo...@li...
> >
> >--=====================_375504166==_
> >Content-Type: text/plain; charset="us-ascii"; format=flowed
> >
> >Hi,
> >
> >Not sure if this one is worth keeping, but since you're updating the
> >databases for the new versions, I decided to write something to change up
> >the admin interface a little bit.  The add-on was implemented in order to
> >have drop-down menus for values such as "blogLocale" and
> >"blogTemplate."  Having no desire to slow down the administration
> > interface with a directory reading script with checking (would not
> > include a template for "misc" or "register"), I figured the easiest
> > method would be to store these values inside of the database. 
> > adminlistvalues does nothing but retrieve these entries inside the table
> > and return them in an array.
> >
> >Included is adminlistvalues.class.php, modified
> >adminblogsettingsaction.class.php, modified blogsettings.template, and new
> >sql dump file for the new table, "listings."
> >
> >Usage should be self-explanatory.
> >
> >Future possible usages could be in "install template" or "install new
> >language/locale" plugins, something along those lines.  This is just a
> >make-up preference change for testers who may have other users testing
> > pLog that do not know which templates or locales are currently available.
> >  Not anything big, but still something worth looking into.  The
> > implementation is flawed -- accessing a database for such simple data is
> > a waste of process time.  Perhaps a "listing.txt" placed in respective
> > directories could be attached with a listing of present
> > templates/locales/etc.
> >
> >I haven't had a chance to download the 0729 branch, but I will as soon as
> > I have time.  Looking forward to seeing the summary page in action :-)
> >
> >
> >Bradley Liang
> >http://www.bliang.com
> >--=====================_375504166==_
> >Content-Type: application/octet-stream; name="adminlistvalues.rar"
> >Content-Transfer-Encoding: base64
> >Content-Disposition: attachment; filename="adminlistvalues.rar"
> >
> >UmFyIRoHAM+QcwAADQAAAAAAAAC5unTggCQAAAAAAAAAAAACAAAAABqg/S4UMAQAEAAAAGluaX
> >SJ
> > pHQggDEAIQEAAJ8DAAACVlorNUaf/S4dMxEAIAAAAGluaXRcbGlzdGluZ3Muc3FsDdkVCMvVw
> >Ve8
> > kPB+SXoGyVkH+JYtsega70ChaSgMj1BqXSpJtCw3SRvvbKEom0Wg2MVi9KvgnMzn2ZnkmzeZ9
> >zJy
> > Zk+6PvBP3ZcTSuA4PvKQDHlmgPNLUYZJQPbzfLEhoo85n00rW8SOGgJI8AdcxQ4+e9Tqq8gIM
> >Fb+
> > Di5gaZsf2Bm2U2nMhifczlvz9NS4solnBega3SwL4RQ4EUAPmJBZEq1ZPjt1jyOU7rDF61PcY
> >P6I
> > Ie7WT3NC6GdS7azOFNLfddU2jTuKCz/fnm0q+NsWWsvznMnyp3vQvb5Vc/asw6JtFKH8CaCGU
> >RKm
> > YkI/W06l3D/UbnlJq/0GcJoaAlqG0Rv3ALJAMuzJG872UDM8gqBRHeXc16Z5qcdQ9svyQEjBd
> >OCA
> > KQAAAAAAAAAAAAIAAAAACaD9LhQwCQAQAAAAdGVtcGxhdGVzvvJ04IAvAAAAAAAAAAAAAgAAA
> >AAN
> > oP0uFDAPABAAAAB0ZW1wbGF0ZXNcYWRtaW6R2HQggEUAXwMAAOcHAAAC4m25MfWe/S4dMyUAI
> >AAA
> > AHRlbXBsYXRlc1xhZG1pblxibG9nc2V0dGluZ3MudGVtcGxhdGUOIVEMyNvOIVe4PCs+aKlBI
> >sgI
> > R0xOFVKraCVPvqrC2q9UTjbkbQ29ab1jk+inu9SJSE3dczNbcJBWH8PARCc3Mzmc5vM3d8bz/
> >CL8
> > z951Z4PkfibgmcdDA/A7cYachQFp53v3ZLJ3YY4Gu9Yy7oMvcfLzQGwhK6c6RYZWbQ6I68Y/4
> >PlI
> > aEE1kUNjNMDbUWfe7mHRmoIAOiNVKCREIuIQy9e+IlbBBIqZoZ5IgnefTsMzEdLGhEJXjTxcA
> >2Od
> > QQ2Eqh2JpN0S2rOHQhljIWIx+BDnbsiUbRFJnB3MxKIRShWS7UQGFKN6AaKpVWY3o0FCI0ZzM
> >+v/
> > XepgkeyiY5jqrxxjXUIOOKnYqDDDP9mlaYfqaNwUXzbA7aKuLSXPW9kJJKsaxU/0fnUG5N4tL
> >28u
> > FRZV9jfy90zfk8BKgaVuR+Mj/bCuCyQqO1LQSGnlUPxcKbyqvJzZ6OdLFtAcPs17r775qEdM2
> >tb1
> > 6I3Bm1WF6rv9DN0PChx+txmV3tNn1gqmL4kFW9axr8FBsMQUzApMhTcz2TAYbML04Bw6ub1Me
> >UHx
> > xzuFgdlplmTLVvhYFw1YZH8AL+7lyx510VrSeHXMlpN8vLUCjhTSO1lK1UU13tGU0mrYnnNOE
> >Kb4
> > 1mOimd8c2r9WT4NIBj7JaORzHu8t8+lrFTMdBA3oNupFzt6M0p5b1AGJjZwY6quUgTS08Vkvi
> >cLh
> > O8XCFOM1tW+rq9oylfP+plhEU42rL0xGM2X9+SzFYwTNB42bXW+oZzW2L2N+EqSDrvmxa+/l0
> >Ws6
> > RB/ivpBcqxH2pmJ2r0Iz152qf3w0rKekmEv5sgqrOsLJACTfgJCW1osG0dfWIcxgVIp7RInM+
> >528
> > DBEeznE3gVv119h86soHV1taTINO9TpptgOLtPV5EzqCcl8zpjrWXU9nxSEDnoMcvBcH1Uo46
> >0Hh
> > YjoeaTLdAu3F2lQd4/KA/0IwZkucX3ikWVq0ZcH1+B8jTYn2X/N9aa9M2dLV854YC6mPMbJ6q
> >W9Q
> > 2KyLTZA/P6u9Gf+YIx9ebxsFXkTY0SDHpP7Gn4FzA5GB0DxckiV0nmKOg5WiB5LPIXkY8/QhI
> >ted
> > Jv/HomaDis8d+qCPmH5GwEs1+F/U3/3X4wamwr/RUzJcD4dAyf19v0ULOfz/7dyvdCCAQQDyA
> >QAA
> > vgQAAAKs3Vr9e539Lh0zIQAgAAAAYWRtaW5ibG9nc2V0dGluZ3NhY3Rpb24uY2xhc3MucGhwD
> >BWM
> > zMz9GBV7o/CiIJ0OwXR+AX8ja7poGG6cBO2hRxOxgNtPJJybCje70C2iOJpQpJt56WS6+ALoa
> >baJ
> > +PCl8vHSkT8UT8SiennBznhPT2U6qYIMUtEc1WkveavLCGMmmdQkjTLu+ZUEQjMMPjDm6IAHH
> >Fi9
> > ExvBBU2RortcpdnBL8aiTSoTrIpio4I+6giy5XZhlD5uCQTqIkEajbEAQJDHnUJgjUi8ijp7e
> >6ug
> > aR33HUc5aLJNGs1qVE7N1MWs0G+g6n4tmLaeL+k2W0269v78Xi2K8Q8Z7VVvDPVYNhuYO5e1B
> >l8C
> > krCmYZzhKvve8hkbIkOI7pM8Y/si4qpI0jhUuJVhtHbQXYs/U+6CTung5MpOjBIiv95KqPR5F
> >whD
> > I/mTuokMubIv78jwQzDmvTnjf64sg2hHy63If+TnRfI/kHr8O2GdHlsaBqkvs2kscsih0g9V9
> >+1L
> > GHbz3D7pT3tcKHUFBdnt2EzjpwhdEtY/bY2Ey3GFJrha1na6Iu6wvjj5/Ynty8FZdQska/vaD
> >DFn
> > KgR59/O+wv/5/Mh424fihiVsUzErbQptHGHEFbRF//Gtdnwud5CC/U5KYKe7TTz7w/qwkkN3c
> >7di
> > KINA7KFO3oDe8mo49yzr1CWQC61N+39NpKwv+T7BBwtXf57OuDyQZKx0IIA5AN0CAAATBgAAA
> >ria
> > 4njTof0uHTMZACAAAABhZG1pbmxpc3R2YWx1ZXMuY2xhc3MucGhwDB0RDIz9HBl+xUr4PtaEh
> >uKB
> > JKlVfgWSIgEVqRZEiRSqqqonA+Y2k/5jfOEEKe71QkRB82b3NsZCSXwLkhjO3czc7c3jxzf47
> >e3t
> > zt3cWfszPrmeBfbjfZf+Pw0NTe3AIu40621CbtI3EWGxibJD5oygK9pYA37G/wLAHJAc7ZcoX
> >miO
> > 47CBSPkb9LPkgceXaYaxEM086BngfvPYz9XKf7Yb/1+f08Cukwn8dJmSgvA8/XXeyOzErkdxI
> >HMM
> > cxQlXCUyFo+oxK4/KSYQ7D0CRKVeGNGcDBMRdhHLvcQZtAJMfmsy/iVlGQjcE9Mk4jNuVWSAx
> >vDz
> > rFB7MSak1/K7MvJGjgdmwY10yKVtdaiv9wfGhAdTwsB4SsqgpIY8vh3k+bAwkDVAWs+5Pxr7b
> >pc0
> > 5NJYidTFDFo3S6VcwqrTQc030FSqMJhrGHCBwZAtp/CqCWpLPqfefGxhKBs7XEsAhiYZMSoma
> >stQ
> > jebOrVznt65qV+s5lh7G6woM8xX4p4ys9YjDGU3UjDweGR/gZehMKzuh45F7sGrBwv/Zd8bE5
> >HoF
> > /H1C88Sm1aNQHNFJCexxz3176IqbpC15O8Oe3VngF7jFdXn37U1pc1Ab0MLtCpR6szfvxK+8K
> >pk4
> > 7B3TAtSBmp9k6qmHprqJ2KD3i5ZpA7/aRmAbBQi1aotPO7XCCmcckAU9tHKkkGBL1bGJdnbU4
> >oSD
> > Kgh0Xb1230h1ovDrDlv8/50tH8X0dE6f+vvdv3Q4Atc1yNp0J1iO1lLFKVsKVg579w6Q5P3QX
> >rXR
> > bsqeqsauIYm9W/ClS1+K73SARGKrQjfS86dNMR78qBK3piVJ8CGCNykpAqTb9Wn+USVEggJlm
> >6VJ
> > iZGWm0VaB7IhHpjEpfLIXiZvxmdK2cHSROB+KFlWkju0O5gYkFbQzSHWnLFvWs0ZU6yTbfWSe
> >l7+ 0bJsvgp5g6s2vktBzsy/8URfCn9T3I14mp9NDx8X+cQ9ewBABwA=
> >--=====================_375504166==_--
> >
> >
> >
> >
> >--__--__--
> >
> >_______________________________________________
> >Plog-general mailing list
> >Plo...@li...
> >https://lists.sourceforge.net/lists/listinfo/plog-general
> >
> >
> >End of Plog-general Digest
>
> Bradley Liang
> http://www.bliang.com
>
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: Free pre-built ASP.NET sites including
> Data Reports, E-commerce, Portals, and Forums are available now.
> Download today and enter to win an XBOX or Visual Studio .NET.
> http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
> _______________________________________________
> Plog-general mailing list
> Plo...@li...
> https://lists.sourceforge.net/lists/listinfo/plog-general