Re: [Libvncserver-common] Version Info Type

[Christian B. <in...@ch...>]

Am Mon, 26 Sep 2022 10:26:17 +0000
schrieb Johann Obermayr via LibVNCServer-common
<lib...@li...>:

> Hallo,
> 
> why is the VERSION format changed after 0.9.11 ?
> 
> #define LIBVNCSERVER_PACKAGE_VERSION  "0.9.11"
> #define LIBVNCSERVER_VERSION "0.9.11"
> #define LIBVNCSERVER_VERSION_MAJOR 0
> #define LIBVNCSERVER_VERSION_MINOR 9
> #define LIBVNCSERVER_VERSION_PATCHLEVEL 11
> 
> With Version 0.9.12 we get 
> #define LIBVNCSERVER_PACKAGE_VERSION  "0.9.12"
> #define LIBVNCSERVER_VERSION "0.9.12"
> #define LIBVNCSERVER_VERSION_MAJOR "0"
> #define LIBVNCSERVER_VERSION_MINOR "9"
> #define LIBVNCSERVER_VERSION_PATCHLEVEL "12"
> 

Hi Johann, 

I think this happened with
https://github.com/LibVNC/libvncserver/commit/fef4386accfe686abc304e43fec235eefdbacd3e
and showed up with the switch to CMake and the removal of Autotools. It clearly
is an oversight.

If you want to contribute a patch via GitHub, I'll happily merge it.

Best regards,
-- 
Christian Beier

what is, is; what is not is possible.