[Libvncserver-common] X509 certificate verification and SASL support

[Simon W. <sim...@zy...>]

Hi,

I've been experimenting with Quacamole connecting to the VNC server in QEMU and in particular
with the more 'enterprise-like' authentication options of X509 and SASL.  In the process I've created
a couple of patches to libvncclient.

The first is a simple patch that adds server certificate verification to the GNUTLS implementation
replacing the 'TODO' in tls_gnutls.c.
The second adds SASL support (both with and without X509) including a few new callbacks to
capture authname and SASL mechanism preference.  The SASL implementation is derived from the
existing GTK VNC viewer implementation.

About the only thing not included in the SASL implementation is support for user interaction primarily
because Guacamole doesn't currently support it.

Is there any interest amongst the maintainers to consider these patches for inclusion in libvncclient and if so, is it best to post the patches here or submit a Git pull request?

If anyone else is interested in the patches I'll be happy to provide them.

Simon
Zynstra is a private limited company registered in England and Wales (registered number 07864369). Our registered office and Headquarters are at The Innovation Centre, Broad Quay, Bath, BA1 1UD. This email, its contents and any attachments are confidential. If you have received this message in error please delete it from your system and advise the sender immediately.