[Libvisual-devel] API Questions

[<pl...@ip...>]

Hi,

I took a look at libvisual CVS (mostly because I want to get rid of
that xmms-1.x dependency). I'm planning to port both gmerlin_visualizer
and lemuria to libvisual. This means, I'll need libvisual on both the
application level as at plugin level.

Some questions (Copy & Paste from ViewCVS):

/libvisual-display/lvdisplay/lv_display.h:

   94 LvdFPSControl *sleep26_fps_control_init();
   95 LvdFPSControl *null_fps_control_init();
   96 LvdFPSControl *tod_fps_control_init();

Shouldn't this be just one function, which tests for supported
sleep/timing modes at runtime?

/libvisual-display/drivers/glx/glx.c:

  249 	attr[i++] =3D GLX_RED_SIZE;	attr[i++] =3D 5;
  250 	attr[i++] =3D GLX_GREEN_SIZE;	attr[i++] =3D 5;
  251 	attr[i++] =3D GLX_BLUE_SIZE;	attr[i++] =3D 5;
  252 	attr[i++] =3D GLX_DOUBLEBUFFER; attr[i++] =3D True;
  253 	attr[i++] =3D GLX_DRAWABLE_TYPE; attr[i++] =3D GLX_WINDOW_BIT;

This is, what lemuria needs:

  int attr_list[] =3D {
    GLX_RGBA,
    GLX_DEPTH_SIZE, 16,
    GLX_ALPHA_SIZE, 8,
    GLX_DOUBLEBUFFER,
    None
  };

Would it be possible for plugins to request their own GLX Attributes?

Cheers

Burkhard