Re: [Libvisual-devel] NetBSD packages for libvisual available; patches

[Dennis S. <sy...@yo...>]

On Mon, 2004-11-08 at 15:33 +0100, Thomas Klausner wrote:
> Perhaps I wasn't clear enough on this -- it's not an actual
> problem, everything works even if the test is unchanged.

Hmms, alright, would be nice to have it going smooth tho :)

> Actually, that's very easy to fix, see attached diff. It's just
> a message :)

Aah doh, thanks for the patch! :)

> In the meantime I also made a package libvisual-gforce, which has
> only one problem: the check in unix/Headers/trunc.h doesn't work
> for me, since NetBSD does not have trunc(), but all of the tests
> are in #ifdef HAVE_CONFIG_H, and the configure script does not
> generate a config.h, but adds -Ds to the command line instead.
> 
> Also, the configure script doesn't even seem to check for trunc().

Hmms, same story, I suck with all these tools, do you think you can
brew up a patch for this ?

Another thing we could do is just always use:

#define trunc(x) (((x) > 0.0) ? floor(x) : ceil(x))

But that might has a speed penalty...

> If the trunc()-arguments are positive, one could use floor() instead,
> which is in C89 and thus probably more portable. (trunc() is new
> in C99.)

Never knew, ported this over quite roughly ;)

> libvisual-nebulus packaged without any problems.

Yay! :)

Cheers,
Dennis