[Libvisual-devel] NetBSD packages for libvisual available; patches

[Thomas K. <tho...@us...>]

Hi!

I just made NetBSD packages for libvisual (0.1.7), libvisual-plugins
(0.1.7), and libvisual-bmp (0.1.0). (pkgsrc/audio/libvisual*)

I needed two patches for libvisual that should be integrated in
the main tree in some form.

The first (patch-aa) deals with lv_common.h defining uint8_t
and friends, not caring if they are already defined.

The second (patch-ab) addresses lv_mem.h's use of
__attribute_malloc__ which seems to be a glibc'ism.
Of course, you could also hide it in more appropriate
ifdefs (something like __GLIBC__?).

Also, the configure script complains about libdl missing;
however, on NetBSD (and the other BSDs too, I think) libdl
is not needed, the dl* functions are in libc itself. At
least it doesn't stop here :)

libvisual-bmp has the following problem: it comes with the two
pixmaps libvisual-xmms-vis.bmp and libvisual-xmms-vis.xpm,
but looks for libvisual-bmp-vis.bmp during runtime. The files
should be renamed (and pixmaps/Makefile.am adapted).

And libvisual-plugins is lying to me -- the configure script
says:
install path                          : /usr/pkg/libvisual
while in reality, the plugins go into /usr/pkg/lib/libvisual.


I also tried using the plugins with bmp, and I get lots of:
	libvisual CRITICAL: XMMS plugin: visual_mem_free(): assertion `ptr != NULL' failed
lines. Other errors I see (not so often):

On startup, right after "Last plugin: infinite":
libvisual CRITICAL: XMMS plugin: visual_plugin_load(): assertion `ref != NULL' failed

Right before "negotiating plugin libvisual DNA helix animation"
and "negotiating plugin libvisual madspin port":
libvisual CRITICAL: XMMS plugin: visual_video_free_buffer(): assertion `video->screenbuffer != NULL' failed

Sometimes when switching:
libvisual WARNING: XMMS plugin: visual_video_free_with_buffer(): VisVideo structure doesn't have an allocated screen buffer, visual_video_free() must be used
libvisual WARNING: XMMS plugin: visual_video_free_with_buffer(): VisVideo structure doesn't have an allocated screen buffer, visual_video_free() must be used

Also, sometimes when disabling the plugin in bmp:
libvisual CRITICAL: XMMS plugin: visual_actor_destroy(): assertion `actor != NULL' failed
libvisual CRITICAL: XMMS plugin: visual_video_free_with_buffer(): assertion `video != NULL' failed

Tell me how I can help debugging them.

Cheers,
 Thomas

P.S.: Please CC me, I'm not on this mailing list.