[Libvisual-devel] Re: log verboseness

[Duilio J. P. <dp...@fc...>]

> I'm very happy with the system you implemented, I've got 1 comment
> and 1 question. First, there is no enum yet to entirely disable
> visual_log output, I think that VERBOSENESS_NONE should be really
> none verbose.

Is true. Now the levels are:

typedef enum {

        VISUAL_LOG_VERBOSENESS_NONE,    /**< Don't show any message at
					all. */

        VISUAL_LOG_VERBOSENESS_LOW,     /**< Show only VISUAL_LOG_ERROR
					and                                        
					VISUAL_LOG_CRITICAL messages. */

        VISUAL_LOG_VERBOSENESS_MEDIUM,  /**< Show all log messages
					except VISUAL_LOG_DEBUG ones. */

        VISUAL_LOG_VERBOSENESS_HIGH     /**< Show all log messages. */

} VisLogVerboseness;


> One more question, I really like the message handle system, I wonder
> if it would be possible to also have a 'all messages' handler that
> can be optionally set. This would be nice for an app that just wants to
> redirect ALL output. Another thing is that the handler set function 
> should accept a void *priv, if the app wants the handler function to 
> handle a private. Let's say a GtkWidget in which text has to be printed.

Ok, the signature of the message handler was moved to:

void visual_log_message_handler_func_t (const char *message,
                                 const char *funcname, void *privdata);

and there is a new function visual_log_set_all_messages_handler().

Thanks a lot for the suggestions!


Bye,
Duilio.