Re: [Libvisual-devel] Libvisual mem bug

[Vitaly V. B. <vit...@us...>]

On Tue, 28 Sep 2004 00:52:47 +0200
Dennis Smit <sy...@yo...> wrote:

> On Tue, 2004-09-28 at 00:43 +0100, salsaman wrote:
> > Any chance of a diff just for this issue so I can patch LiVES before 
> > tomorrow's performance ?

> Remove the visual_list_destroy from visual_param_container_destroy in 
> libvisual/lv_param.c

Or, better IMO, visual_list_free() from visual_list_destroy() in lv_list.c.
This WILL LEAK Memory, but won'r thrash malloc state... there is one more
here, Dennis.


in lv_event.c:

int visual_event_queue_free (VisEventQueue *eventqueue)
{
        visual_log_return_val_if_fail (eventqueue != NULL, -1);

        visual_list_destroy (&eventqueue->events, free);

        visual_mem_free (eventqueue);

        return 0;
}

int visual_list_destroy (VisList *list, visual_list_destroy_func_t destroyer)   
{
	...
        visual_list_free (list);
}

> Btw I had a hang on gforce once in the Arena preset, so it's not
> something on your machine, so it seems. I'm going to try to debug
> this but it's pretty hard because I don't have a pattern to
> recreate the hang, it happens almost never here.


PS. Dennis, are you sure your new plugin selection algo in lv-plugins
works the right way? It just visits all dirs and builts nothing.

First, configure.ac:
    AC_DEFINE([ALSALA], [input_alsa.la], [alsa input plugin dynamic library name
    ALSALA=input_alsa.la # Missed (?)
    AC_SUBST(ALSALA)
Is AC_DEFINE necessary? it created definition in config.h.in...

After fixing this, only static "plugin" built. with ".a" extension...

[vitalyb@vb vitalyb]$ automake --version
automake (GNU automake) 1.7.9

[vitalyb@vb vitalyb]$ autoconf --version
autoconf (GNU Autoconf) 2.59


-- 
Vitaly
GPG Key ID: F95A23B9