Re: [Libvisual-devel] New input plugin: mplayer

[Gustavo S. B. <gu...@gs...>]

Em Tuesday 13 July 2004 13:28, Dennis Smit escreveu:
> On Mon, 2004-07-12 at 22:13 -0300, Gustavo Sverzut Barbieri wrote:
> > Hello,
> >
> > I've commited a new input plugin: mplayer. It can use data exported by
> > mplayer audio filter "export" (mplayer -af export).
> >
> > After 3 commits (sorry! I'm really distracted today) it's stable.
> >
> > I also did small changes to esd and alsa. The focus was to ensure
> > pointers were not null and to use visual_log() instead of fprintf().
> >
> > Any comments?
> >
> > PS: There is a way to get input plugin parameters? I'll need that.
>
> Hello,
>
> Thanks a LOT for commiting your mplayer plugin and for replacing the
> fprintfs with visual_logs!
>
> However you've forgotten to update the ChangeLog file, please do update
> it ! :)

Done!


> Plugin parameters is being worked out, but the lack of time is slowing
> me down. But it'll be there soon!

Ok.


> Btw, please don't do too much NULL checking within the plugins. If
> someone goes wrong all down at this layer something is majorly borked
> within libvisual itself or the user is creating hacky code. The
> abstraction system, VisInput, VisMorph, VisActor do handle most of the
> situations. Thanks anyway ;)

That's why I always do NULL checking, to know if there's something wrong. If 
everbody code it right we are not humans... so errors may appear and better 
catch them as soon as possible.

Since most of segfaults are caused by null pointers I think worth checking for 
them always...

-- 
Gustavo Sverzut Barbieri
---------------------------------------
Engenharia de Computacao 2001 - UNICAMP
GPSL - Grupo Pro Software Livre
Cell..: +55 (19) 9165 8010
Jabber: gsb...@ja...
  ICQ#: 17249123
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net