Re: [Libvisual-devel] New input plugin: mplayer

[Dennis S. <sy...@yo...>]

On Mon, 2004-07-12 at 22:13 -0300, Gustavo Sverzut Barbieri wrote:
> Hello,
> 
> I've commited a new input plugin: mplayer. It can use data exported by mplayer 
> audio filter "export" (mplayer -af export).
> 
> After 3 commits (sorry! I'm really distracted today) it's stable.
> 
> I also did small changes to esd and alsa. The focus was to ensure pointers 
> were not null and to use visual_log() instead of fprintf().
> 
> Any comments?
> 
> PS: There is a way to get input plugin parameters? I'll need that.

Hello,

Thanks a LOT for commiting your mplayer plugin and for replacing the
fprintfs with visual_logs!

However you've forgotten to update the ChangeLog file, please do update
it ! :)

Plugin parameters is being worked out, but the lack of time is slowing
me down. But it'll be there soon!


Btw, please don't do too much NULL checking within the plugins. If
someone goes wrong all down at this layer something is majorly borked
within libvisual itself or the user is creating hacky code. The
abstraction system, VisInput, VisMorph, VisActor do handle most of the
situations. Thanks anyway ;)

Cheers,
Dennis

> 
> 
> Here is the first revision with a bit more explanation:
> 
> revision 1.1
> date: 2004/07/12 23:51:12;  author: gsbarbieri;  state: Exp;
> Added mplayer input plugin.
> 
> Background:
>         Mplayer has an export filter which export it's buffer to a file
>         using mmap().
> 
> TODO:
>         * Implement option to change shared file. Current implementation
>           uses default mplayer value (~/.mplayer/mplayer-af_export)
>         * Support different number of channels (current is fixed to 2),
>           different buffer size (current is 512 samples) and different
>           format (current is 16bits signed).
> 
> BUGS:
>         * Some mplayer audio output system changes the rate mplayer calls
>           its export filter, leading to low update rate. Know problematic
>           output system: esd. Know to work right: alsa, oss. This is not
>           a big issue since you can use libvisual own esd input plugin and
>           get it right. NOTE: This is a mplayer bug.
> =============================================================================
> 
>