Re: [Libvisual-devel] Re: actor_get_prev/next stuff for the xmms plugin.

[Dennis S. <sy...@yo...>]

On Thu, 2004-07-08 at 00:02 -0300, Duilio Javier Protti wrote:
> > I've done the following commit:
> > 
> > 2004-07-07  Dennis Smit  <ds...@ne...>
> > 
> >         * libvisual/lv_actor.c:
> >         (visual_actor_get_next_by_name_gl,
> >         visual_actor_get_prev_by_name_gl,
> >         visual_actor_get_next_by_name_nogl,
> >         visual_actor_get_prev_by_name_nogl):
> >         New methods.
> > 
> > 
> > 
> > These methods can be used to filter out certain types of plugins.
> > 
> > Duilio I suggest the following:
> > 
> > Instead of a checkbox to 'disable gl plugins'
> > have three radio buttons grouped that do either:
> > 
> > 'Only GL plugins'
> > 'Only non GL plugins'
> > 'All types of plugins'
> > 
> > Or something likewise.
> > 
> > I've updated the xmms plugin to use the API and remove the non GL hack.
> > 
> > What do you think ?
> > 
> > Cheers,
> > Dennis
> 
> Good, is much clear this way.
> 
> I have submitted the version with the three radiobuttons (along 
> with the Glade file), but now I need a
> visual_actor_get_next_by_name_gl() function :-)

Good work, btw I had already checked in the _name_gl methods!!!

        * libvisual/lv_actor.c:
       (visual_actor_get_next_by_name_gl,
        visual_actor_get_prev_by_name_gl,

I want this application API very abstract and this is being the reason
why I rather have many methods than exposing the app writer to 
internals.

>  This way we
> can use get_next/get_prev functions for others things that just have
> the name of an actor, an we don't need to add functions for every
> new criteria for which we want to filter the list, but instead we
> just walk through the list and take what we want.

The user can always request a VisList full of VisPluginRefs by doing:
visual_actor_get_list. From there on he can check the 
LVPlugin->plugin.actorplugin->.... stuff. Tho this is not cached and
needs to be retrieved by the init function from the plugin (which is
basicly loading the plugin) but not realizing it. I will move the
_lv_plugin functions to visual_plugin functions to get the API public.

Cheers,
Dennis