[Libvisual-devel] design

[Duilio J. P. <dp...@fc...>]

> Btw now you're getting more indepth with the system, how
> do you like the overall design ? ofcourse there are some
> rough edges here and there, both API, design and
> implementation wise...

I think the module design is perfect, however I have
not seen exhaustively the interface offered by every
module.

I think next step must be enforce all preconditions to
catch bugs:

int visual_some_thing (VisSome *vis)
{
  if (vis == NULL)
    return -1;
}

must be changed for:

int visual_some_thing (VisSome *vis)
{
  assert (vis != NULL);
  ...
}

This way we can catch them early, before the bug
propagate to obscure places. This is on the devel
line and just for a while, to clean up things and
to detect where the problems are, before to
change the VisBin module or create the new param
module.
On the final release we will use a nice macro 
_lv_return_if_null(), as you suggest on the TODO
list, that will show a critical warning but will
not abort.


Duilio.