libvisual-devel

[Libvisual-devel] VisObject

[Dennis S. <sy...@yo...>]

Some random thoughts on VisObject:

Object hierachy:
VisObject
	VisUI
		VisUI...
	VisActor
	VisInput
	VisPlugin
	etc


Implement Ref counting at VisObject layer.

Most important API addition for now:
	visual_object_ref (VisObject *object);
	visual_object_unref (VisObject *object);

VisObject {
	int refcount;
	VisObjectDtorFunc dtor;
}

Example for a random structure:

VisActor {
	VisObject object;

	blah;
	blah;
}

visual_actor_new ()
{
	VisActor *actor = ...

	VISUAL_OBJECT (actor)->dtor = dtor_actor;

}

visual_object_unref (obj)
{
	obj->ref--

	if (obj->ref <= 0)
		obj->dtor (obj);
}

Problems to be solved:
How to implement the automatic dtorring.

Being able to set a dtor for an object ?

This could also exterminate the ugly switches in VisUI that are used for
a VisUI object dtoring.




Please comment on this :)

[Libvisual-devel] VisObject

[Dennis S. <sy...@yo...>]

Alright, most of the libvisual system is now in the VisObject fashion.

This introduces the following API functions:

VisObject *visual_object_new (void);
int visual_object_free (VisObject *object);
int visual_object_destroy (VisObject *object);

int visual_object_ref (VisObject *object);
int visual_object_unref (VisObject *object);

int visual_object_set_private (VisObject *object, void *priv);
void *visual_object_get_private (VisObject *object);



Nearly every libvisual structure (like VisActor / VisSongInfo etc etc)
can be cast into a VisObject using object = VISUAL_OBJECT (actor);

This way we provide a generalized ref counting interface. That
also supports complex object desctructors that are set at object
creation. With this change most of the other _free and _destroy
functions are history and object disposing should be done using
an visual_object_unref, and if you're really sure visual_object_destroy.

To get this working, EVERY libvisual module needs a recompile.

I haven't updated lvdisplay to this, Vitaly would you like to take
a look at VisObjectifying lvdisplay ?

VisUI and lv_plugin.c still needs to be done, I will most likely do
that tomorrow in the evening.

Cheers,
Dennis

Re: [Libvisual-devel] VisObject

[Vitaly V. B. <vit...@uk...>]

On Wed, 24 Nov 2004 00:21:17 +0100
Dennis Smit <sy...@yo...> wrote:

> This way we provide a generalized ref counting interface. That
> also supports complex object desctructors that are set at object
> creation. With this change most of the other _free and _destroy
> functions are history and object disposing should be done using
> an visual_object_unref, and if you're really sure visual_object_destroy.
It would be nice to have some list of "deprecated" functions.

> To get this working, EVERY libvisual module needs a recompile.
> 
> I haven't updated lvdisplay to this, Vitaly would you like to take
> a look at VisObjectifying lvdisplay ?
Done. Initial version.

IMO everyting looks much better now!

-- 
Vitaly
GPG Key ID: F95A23B9

Re: [Libvisual-devel] VisObject

[Dennis S. <sy...@yo...>]

On Wed, 2004-11-24 at 21:35 +0200, Vitaly V. Bursov wrote:
> On Wed, 24 Nov 2004 00:21:17 +0100
> Dennis Smit <sy...@yo...> wrote:
> 
> > This way we provide a generalized ref counting interface. That
> > also supports complex object desctructors that are set at object
> > creation. With this change most of the other _free and _destroy
> > functions are history and object disposing should be done using
> > an visual_object_unref, and if you're really sure visual_object_destroy.
> It would be nice to have some list of "deprecated" functions.

Well, every _destroy and _free function except that of visual_object :)

I haven't been really recording added and removed methods yet... You're
right, we should do that a bit more active, but on the other side, we
aren't yet stable API/ABI wise ;)

> > To get this working, EVERY libvisual module needs a recompile.
> > 
> > I haven't updated lvdisplay to this, Vitaly would you like to take
> > a look at VisObjectifying lvdisplay ?
> Done. Initial version.
> 
> IMO everyting looks much better now!

Thank you!, It looks really nice don't you think ?, I'm glad how it
turned out.

It also fixes many internal issues, like that we couldn't keep the
config UI around after a plugin has been unloaded, now we can just
refcount all the things involved and when the plugin unloads we still
have our data.

Cheers,
Dennis