Menu
▾
▴
libvisual-devel
|
From: Duilio J. P. <dp...@fc...> - 2004-11-20 05:43:28
|
>Do you have a suggestion for the work around combobox thingy ? > >Cheers, >Dennis I see three possibilities here: - Avoid the use of GtkComboBox within libvisual-widgets. - Use GtkComboBox, and give our own implementation when gtk2 < 2.4. - Require gtk2 >= 2.4. The second option is not so much weird as it appears on a first look: if we decide to use GtkComboBox, even if we require gtk2 >= 2.4, we will need to implement combobox for the gtk1 port anyway, because combobox doesn't exists on gtk1 and it will never do. IMHO, the first option is the best, but just a suggestion... Bye, Duilio. |
|
From: Dennis S. <sy...@yo...> - 2004-11-22 15:53:33
|
I think it's best to use GtkOptionMenu with gtk < 2.4 and I bet there is something like that for gtk 1.2 as well :) What do you think ? On Sat, 2004-11-20 at 02:44 -0300, Duilio Javier Protti wrote: > >Do you have a suggestion for the work around combobox thingy ? > > > >Cheers, > >Dennis > > I see three possibilities here: > > - Avoid the use of GtkComboBox within libvisual-widgets. > - Use GtkComboBox, and give our own implementation when gtk2 < 2.4. > - Require gtk2 >= 2.4. > > The second option is not so much weird as it appears on a first look: if > we decide to use GtkComboBox, even if we require gtk2 >= 2.4, we will > need to implement combobox for the gtk1 port anyway, because combobox > doesn't exists on gtk1 and it will never do. > > IMHO, the first option is the best, but just a suggestion... > > > Bye, > Duilio. |
|
From: Duilio J. P. <dp...@fc...> - 2004-11-23 04:28:28
|
Ok, I think it's a good idea. I can send a patch to configure.ac and lvw_gtk2_visui.c to work around this. Bye, Duilio. > I think it's best to use GtkOptionMenu with gtk < 2.4 > > and I bet there is something like that for gtk 1.2 as well :) > > What do you think ? |
|
From: Dennis S. <sy...@yo...> - 2004-11-23 10:41:54
|
Would be EXCELENT!! :) Thanks! On Tue, 2004-11-23 at 01:30 -0300, Duilio Javier Protti wrote: > Ok, I think it's a good idea. I can send a patch to configure.ac and > lvw_gtk2_visui.c to work around this. > > > Bye, > Duilio. |
|
From: Duilio J. P. <dp...@fc...> - 2004-11-23 23:07:36
|
I'm having big troubles here, because G_TYPE_INSTANCE_GET_PRIVATE and G_DEFINE_TYPE macros are not defined on gtk2 < 2.4, so I must provide one, but first I will take a look at the semanthic of this things... Bye, Duilio. > Would be EXCELENT!! :) > > Thanks! > > > On Tue, 2004-11-23 at 01:30 -0300, Duilio Javier Protti wrote: > > Ok, I think it's a good idea. I can send a patch to configure.ac and > > lvw_gtk2_visui.c to work around this. > > > > > > Bye, > > Duilio. |
|
From: Duilio J. P. <dp...@fc...> - 2004-11-23 23:41:53
|
The problem is not G_DEFINE_TYPE, which could be easily defined, but
G_TYPE_INSTANCE_GET_PRIVATE, which needs
g_type_class_{add/get}_private() functions. I think we need another way
to save the private info.
Bye,
Duilio.
|
|
From: Dennis S. <sy...@yo...> - 2004-11-24 00:54:44
|
Suggestions ?, we could have an extra entry in the object instance
structure..
Cheers,
Dennis
On Tue, 2004-11-23 at 20:43 -0300, Duilio Javier Protti wrote:
> The problem is not G_DEFINE_TYPE, which could be easily defined, but
> G_TYPE_INSTANCE_GET_PRIVATE, which needs
> g_type_class_{add/get}_private() functions. I think we need another way
> to save the private info.
>
>
> Bye,
> Duilio.
>
>
>
>
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://productguide.itmanagersjournal.com/
> _______________________________________________
> Libvisual-devel mailing list
> Lib...@li...
> https://lists.sourceforge.net/lists/listinfo/libvisual-devel
|
|
From: Duilio J. P. <dp...@fc...> - 2004-11-24 23:27:46
|
I have found a way to fix this, the only issue is that glib will doesn't have knowledge about the private info, but I think that's not a problem on our context (the destroyer will get data he needs). I hope to have the patch tomorrow. Bye, Duilio. > Suggestions ?, we could have an extra entry in the object instance > structure.. > > Cheers, > Dennis |
|
From: Dennis S. <sy...@yo...> - 2004-11-25 12:57:14
|
Alright, sounds excelent, I'm looking forward to the patch! On Wed, 2004-11-24 at 20:29 -0300, Duilio Javier Protti wrote: > I have found a way to fix this, the only issue is that glib will doesn't > have knowledge about the private info, but I think that's not a problem > on our context (the destroyer will get data he needs). > > I hope to have the patch tomorrow. > > > Bye, > Duilio. |
|
From: Duilio J. P. <dp...@fc...> - 2004-11-26 04:56:26
Attachments:
lvw-duilio-alpha1.patch
|
Ok, I send here a (incomplete) patch. With the simple test program:
#include <gtk/gtk.h>
#include <lvw/gtk2/lvw_gtk2_visui.h>
int main (int argc, char *argv[])
{
VisUIWidget *lvwidget;
GtkWidget *window, *widget;
window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
lvwidget = visual_ui_label_new ("Hello World!", FALSE);
widget = lvw_visui_new (lvwidget);
gtk_container_add (GTK_CONTAINER(window), widget);
gtk_widget_show (widget);
gtk_widget_show (window);
return 0;
}
I have the following errors:
(process:11354): GLib-GObject-CRITICAL **: gtype.c:1871: initialization
assertion failed, use g_type_init() prior to this function
(process:11354): GLib-GObject-CRITICAL **: gtype.c:1871: initialization
assertion failed, use g_type_init() prior to this function
(process:11354): GLib-GObject-CRITICAL **: gtype.c:1871: initialization
assertion failed, use g_type_init() prior to this function
(process:11354): GLib-GObject-CRITICAL **: file gtype.c: line 1937
(g_type_add_interface_static): assertion `G_TYPE_IS_INSTANTIATABLE
(instance_type)' failed
(process:11354): GLib-GObject-CRITICAL **: gtype.c:1871: initialization
assertion failed, use g_type_init() prior to this function
(process:11354): GLib-GObject-CRITICAL **: gtype.c:1871: initialization
assertion failed, use g_type_init() prior to this function
(process:11354): GLib-GObject-CRITICAL **: gtype.c:1871: initialization
assertion failed, use g_type_init() prior to this function
(process:11354): GLib-GObject-CRITICAL **: file gobject.c: line 615
(g_object_new): assertion `G_TYPE_IS_OBJECT (object_type)' failed
Segmentation violation
I'm doing something wrong? If somebody have another test for
libvisual-widgets (that knows it works) please send to the list.
I'll keep working on this tomorrow.
Bye,
Duilio.
|
|
From: Dennis S. <sy...@yo...> - 2004-11-26 14:50:39
|
There are some errors in your test setup, I added them mixed with
the qouted part, look at it :)
>
> #include <gtk/gtk.h>
> #include <lvw/gtk2/lvw_gtk2_visui.h>
>
>
> int main (int argc, char *argv[])
> {
> VisUIWidget *lvwidget;
VisActor *actor;
> GtkWidget *window, *widget;
gtk_init (&argc, &argv);
visual_init (&argc,&argv);
> window = gtk_window_new (GTK_WINDOW_TOPLEVEL);
> // lvwidget = visual_ui_label_new ("Hello World!", FALSE);
actor = visual_actor_new ("bumpscope");
visual_actor_realize (actor);
lvwidget = visual_plugin_get_userinterface (visual_actor_get_plugin (actor));
>
> widget = lvw_visui_new (lvwidget);
>
> gtk_container_add (GTK_CONTAINER(window), widget);
> // gtk_widget_show (widget);
>
> gtk_widget_show_all (window);
>
gtk_main ();
>
> return 0;
> }
>
>
>
> I'm doing something wrong? If somebody have another test for
> libvisual-widgets (that knows it works) please send to the list.
Here ya go :)
> I'll keep working on this tomorrow.
Cool, would be great to have it working on both gtk2.4 and (> 2.4)
Thanks,
Dennis
|
|
From: Dennis S. <sy...@yo...> - 2004-11-26 14:52:38
|
As a reply to your patch, could you explain a bit what you're doing, I don't think we need this new gobject boiler plating. I prefer to just set a pointer in our base class th a private and allocate it when you can't use gobject it's private system. Think about it. |
|
From: Duilio J. P. <dp...@fc...> - 2004-11-27 04:24:50
Attachments:
lvw-duilio-alpha2.patch
|
Dennis, thanks a lot for the test program! Here I send attached the patch for libvisual-widgets with gtk+ < 2.4, which works really well on my system (gtk+ 2.2.2), but please test if you can. I will start to work on the gtk1 port, so when finished we can add per-plugin config dialogs to libvisual-xmms. Bye, Duilio. |
|
From: Dennis S. <sy...@yo...> - 2004-11-27 12:13:31
|
On Sat, 2004-11-27 at 01:27 -0300, Duilio Javier Protti wrote: > Dennis, thanks a lot for the test program! Here I send attached the > patch for libvisual-widgets with gtk+ < 2.4, which works really well on > my system (gtk+ 2.2.2), but please test if you can. > > I will start to work on the gtk1 port, so when finished we can add > per-plugin config dialogs to libvisual-xmms. Alright you can, but keep in mind that the gtk2 widget isn't yet totally finished and needs a few cleanups, and I've got a theory about a possible thread race condition that would be fatal (very unlikely but it's there) I need to figure that out.. I advice you to wait till that is fixed, and then port the whole stuff over... But that is completely up to you. Also VisCPU needs a bit more attention maybe you can look at bit more to that ;) Thanks for the patch, I'm going to look at it and put it in CVS! How do you like the VisUI implementation btw ? :) Ooh about the libvisual-xmms/bmp clients... When lvdisplay is a bit more further (a few weeks) I think it's best to drop the current implementations, design a new one and do it from scratch. Cheers, Dennis |
|
From: Dennis S. <sy...@yo...> - 2004-11-27 14:04:15
|
Heya, I've changed a few things in CVS regarding the gtk2.4< popup thingy, take a look. Also the GTK >= 2.4 check seems to fail. It's compiling the GtkRadioMenuItem thingy instead of combobox at my machine. While I'm on gtk CVS :) Cheers, Dennis |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X