From: Duilio J. P. <dp...@fc...> - 2004-09-24 16:18:13
|
I have make a new configure dialog for xmms plugin, please take a look. About the API update, I have to add it a new visual_is_initialized() function to known where libvisual is already initialized, otherwise I have one of two problems: - I call visual_init() again, and fail because of overinitialization. - Or if libvisual is not initialized, I cannot get the plugins list, show correct messages, etc. Waht do you think about this new function, Dennis? Bye, Duilio. |
From: Dennis S. <sy...@yo...> - 2004-09-24 21:51:37
|
Heya Duilio, Generally I'm happy with your work! One thing: When creating new function headers, please be conform to the codingstyle Functions with no parameters we declare as blah (void) in the header and as () in the C file. Regarding the xmms plugin: aclocal: configure.ac: 84: macro `AM_GLIB_GNU_GETTEXT' not found in library I'm not sure if you have changed something regarding this, it might be my system... Keep up the good work, and thanks a lot, Dennis On Fri, 2004-09-24 at 13:28 -0300, Duilio Javier Protti wrote: > I have make a new configure dialog for xmms plugin, > please take a look. About the API update, I have to > add it a new visual_is_initialized() function to > known where libvisual is already initialized, > otherwise I have one of two problems: > - I call visual_init() again, and fail because of > overinitialization. > - Or if libvisual is not initialized, I cannot get > the plugins list, show correct messages, etc. > > Waht do you think about this new function, Dennis? > > > Bye, > Duilio. > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170 > Project Admins to receive an Apple iPod Mini FREE for your judgement on > who ports your project to Linux PPC the best. Sponsored by IBM. > Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php > _______________________________________________ > Libvisual-devel mailing list > Lib...@li... > https://lists.sourceforge.net/lists/listinfo/libvisual-devel |
From: Duilio J. P. <dp...@fc...> - 2004-09-25 06:26:53
Attachments:
glib-gettext.m4
|
> Regarding the xmms plugin: > aclocal: configure.ac: 84: macro `AM_GLIB_GNU_GETTEXT' not found in > library > > I'm not sure if you have changed something regarding this, it might > be my system... > > Keep up the good work, and thanks a lot, > Dennis really strange, because you have already built this package after first checkout (with autogen script). But doesn't matter, here is the macro file you have to copy to /usr/share/aclocal/ I have made a little more work on xmms plugin, I hope you can test it soon. Before to build, make 'make distclean' and configure again, because I have renamed two source files, so po/Makefile must be rebuilded (it is not done automatically when moving files). Bye, Duilio. |
From: Dennis S. <sy...@yo...> - 2004-09-25 09:09:09
|
Thank you for the m4 macro Still i'm curous from which package it normally comes. The config window starts to look really good! A few comments: I don't think input plugins have a place in the xmms plugin seen it always gets it data from xmms. Also the app icon config, I don't think that is needed. For the rest, awesome work! On Sat, 2004-09-25 at 03:37 -0300, Duilio Javier Protti wrote: > > Regarding the xmms plugin: > > aclocal: configure.ac: 84: macro `AM_GLIB_GNU_GETTEXT' not found in > > library > > > > I'm not sure if you have changed something regarding this, it might > > be my system... > > > > Keep up the good work, and thanks a lot, > > Dennis > > really strange, because you have already built this package after > first checkout (with autogen script). But doesn't matter, here is > the macro file you have to copy to /usr/share/aclocal/ > > I have made a little more work on xmms plugin, I hope you can test > it soon. Before to build, make 'make distclean' and configure again, > because I have renamed two source files, so po/Makefile must be > rebuilded (it is not done automatically when moving files). > > Bye, > Duilio. > |
From: Duilio J. P. <dp...@fc...> - 2004-09-26 21:37:14
|
> The config window starts to look really good! > > > A few comments: > I don't think input plugins have a place in the xmms plugin seen it > always gets it data from xmms. > > Also the app icon config, I don't think that is needed. > > For the rest, awesome work! You are right on both things! I will finish the configure dialog on the coming week. Bye, Duilio. |