libvisual-devel

[Libvisual-devel] XMMS plugin

[Duilio J. P. <dp...@fc...>]

I have fixed some problems on XMMS plugin, that 
makes XMMS crash when you disable from the configuration
window.
It still not working, but I think remainings problems
are not on the XMMS plugin, but on the Libvisual library
side.

I think I will wait until VisBin code rewrite, and then
see what happens here (the problem is exactly when we
call SDL_Quit()).


Duilio.

[Libvisual-devel] XMMS plugin

[Duilio J. P. <dp...@fc...>]

I have submited some work:

- lv_xmms_render_pcm() now uses a fast memcpy()
instead of a for loop.
- added fullscreen support.


Duilio.

Re: [Libvisual-devel] XMMS plugin

[Dennis S. <sy...@yo...>]

On Thu, 2004-06-24 at 22:01 -0300, Duilio Javier Protti wrote:
> I have submited some work:
> 
> - lv_xmms_render_pcm() now uses a fast memcpy()
> instead of a for loop.
If you'd like, you might like to redo the whole plugin
with some more config stuff and such, the plugin as it is
is one big hack used as testing and everytime hackily adapted
to changes.

> - added fullscreen support.
Wasn't that already there ?

Cheers,
Dennis

[Libvisual-devel] XMMS plugin

[Duilio J. P. <dp...@fc...>]

Now the window title is set to the
name of the current plugin.

Also, I have added error checking to
visual_bin_run() and others, and with
these at least the plugin now doesn't
hang my terminal on exit, but still
crashing XMMS.


Bye,
Duilio.

Re: [Libvisual-devel] XMMS plugin

[Dennis S. <sy...@yo...>]

On Tue, 2004-06-29 at 21:12 -0300, Duilio Javier Protti wrote:
> Now the window title is set to the
> name of the current plugin.
> 
> Also, I have added error checking to
> visual_bin_run() and others, and with
> these at least the plugin now doesn't
> hang my terminal on exit, but still
> crashing XMMS.

valgrind during exit:
==8421==
==8421== Thread 4:
==8421== Invalid read of size 1
==8421==    at 0x3C3BC754: strdup (in /lib/tls/libc-2.3.2.so)
==8421==  Address 0x0 is not stack'd, malloc'd or free'd

Segmentation fault

You've probably found a bug in XMMS, please visit
http://bugs.xmms.org and fill out a bug report.


But this one is more interesting:
valgrind during disable through the xmms plugin config window:
libvisual DEBUG: LibVisual XMMS Plugin: lv_xmms_cleanup [(lv_xmms.c,219)]: calling visual_quit()
==8429==
==8429== Invalid free() / delete / delete[]
==8429==    at 0x3C01F918: free (vg_replace_malloc.c:127)
==8429==    by 0x3CF1F402: visual_list_free (in /usr/lib/libvisual.so.0.0.0)
==8429==    by 0x3CF1C59C: visual_plugin_ref_list_destroy (in /usr/lib/libvisual.so.0.0.0)
==8429==    by 0x3CF20412: visual_quit (in /usr/lib/libvisual.so.0.0.0)
==8429==  Address 0x3C79D238 is 0 bytes inside a block of size 12 free'd
==8429==    at 0x3C01F918: free (vg_replace_malloc.c:127)
==8429==    by 0x3CF1F402: visual_list_free (in /usr/lib/libvisual.so.0.0.0)
==8429==    by 0x3CF1F4A7: visual_list_destroy (in /usr/lib/libvisual.so.0.0.0)
==8429==    by 0x3CF1C592: visual_plugin_ref_list_destroy (in /usr/lib/libvisual.so.0.0.0)
==8429==
==8429== Jump to the invalid address stated on the next line
==8429==    at 0x0: ???
==8429==    by 0x3CF20430: visual_quit (in /usr/lib/libvisual.so.0.0.0)
==8429==    by 0x3CF10A65: lv_xmms_cleanup (lv_xmms.c:220)
==8429==    by 0x806537A: enable_vis_plugin (in /usr/bin/xmms)
==8429==  Address 0x0 is not stack'd, malloc'd or free'd
--8429-- INTERNAL ERROR: Valgrind received a signal 11 (SIGSEGV) - exiting
--8429-- si_code=1 Fault EIP: 0xB806F382; Faulting address: 0x1F

valgrind: the `impossible' happened:
   Killed by fatal signal
Basic block ctr is approximately 142100000
==8429==    at 0xB802FB60: vgPlain_core_panic (vg_mylibc.c:1230)
==8429==    by 0xB802FB5F: panic (vg_mylibc.c:1226)
==8429==    by 0xB802FB80: vgPlain_core_panic (vg_mylibc.c:1231)
==8429==    by 0xB803653A: vg_sync_signalhandler (vg_signals.c:1756)


Hope this helps!

Have you ever used valgrind ? It's an awesome tool, seriously!!!

Cheers,
Dennis

Re: [Libvisual-devel] XMMS plugin

[Dennis S. <sy...@yo...>]

On Wed, 2004-06-23 at 15:13 -0300, Duilio Javier Protti wrote:
> I have fixed some problems on XMMS plugin, that 
> makes XMMS crash when you disable from the configuration
> window.
> It still not working, but I think remainings problems
> are not on the XMMS plugin, but on the Libvisual library
> side.
> 
> I think I will wait until VisBin code rewrite, and then
> see what happens here (the problem is exactly when we
> call SDL_Quit()).

I've seen this as well however been unable to isolate it. Valgrind
doesn't show up any memory errors either. Thanks a lot btw!

I've decided that I'll be doing a release this weekend, work is
exhausting me so when I'm back home I really don't feel like
releasing hehehe :)

Dennis