libvisual-devel

[Libvisual-devel] Take care with arch

[Gustavo S. B. <gu...@gs...>]

Hello Dennis,

I'm coding input_mplayer.c and take a deeper look in libvisual, I noticed that 
you use plain int, short and stuff. We should agree on sizes and use the 
int16_t, int32_t and similar to avoid problems when changing plataforms 
(32->64 bits, for example).

For example:

struct _VisAudio {
        short plugpcm[2][512];

        short pcm[3][512];
        short freq[3][512];

        fft_state *fft_state;

        short int bpmhistory[1024][6];
        short int bpmdata[1024][6];
        short int bpmenergy[6];
        int energy;
};

should be:

struct _VisAudio {
        int16_t plugpcm[2][512];

        int16_t pcm[3][512];
        int16_t freq[3][512];

        fft_state *fft_state;

        int16_t bpmhistory[1024][6];
        int16_t bpmdata[1024][6];
        int16_t bpmenergy[6];
        int32_t energy;
};


Also, if the data is limited to 2 channels of 512 16 bits samples, we should 
provide some helper to merge channels... even if the helper discard the 
channels instead of merge them  (1/3/5/6 channels -> 2 channels)

-- 
Gustavo Sverzut Barbieri
---------------------------------------
Engenharia de Computacao 2001 - UNICAMP
GPSL - Grupo Pro Software Livre
Cell..: +55 (19) 9165 8010
Jabber: gsb...@ja...
  ICQ#: 17249123
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net

Re: [Libvisual-devel] Take care with arch

[Dennis S. <sy...@yo...>]

Gustavo, 

what do you think about an lv_config.h that gets generated
from the config.h.in template ?, i have no experience with this tho.
How can i set up macros in the template that will generate
uint16, int16, (same for 8, 32) for me ?, i'd like to get this fixed
in the next release, also someone reported issues with amd64 so
hopefully it gets fixed, or atleast partialy fixed by using 
these types.

Cheers,
Dennis

On Tue, 2004-04-27 at 22:58 -0300, Gustavo Sverzut Barbieri wrote:
> struct _VisAudio {
>         int16_t plugpcm[2][512];
> 
>         int16_t pcm[3][512];
>         int16_t freq[3][512];
> 
>         fft_state *fft_state;
> 
>         int16_t bpmhistory[1024][6];
>         int16_t bpmdata[1024][6];
>         int16_t bpmenergy[6];
>         int32_t energy;
> };
> 
> 
> Also, if the data is limited to 2 channels of 512 16 bits samples, we should 
> provide some helper to merge channels... even if the helper discard the 
> channels instead of merge them  (1/3/5/6 channels -> 2 channels)
> 

Re: [Libvisual-devel] Take care with arch

[Gustavo S. B. <gu...@gs...>]

Em Tuesday 01 June 2004 08:09, Dennis Smit escreveu:
> Gustavo,
>
> what do you think about an lv_config.h that gets generated
> from the config.h.in template ?, i have no experience with this tho.

Which package? Just downloaded libvisual, ./configure and no lv_config.h, make 
and still none... locate lv_config.h (my system have libvisual installed) and 
nothing.


> How can i set up macros in the template that will generate
> uint16, int16, (same for 8, 32) for me ?, i'd like to get this fixed
> in the next release, also someone reported issues with amd64 so
> hopefully it gets fixed, or atleast partialy fixed by using
> these types.

#include <stdint.h>

-- 
Gustavo Sverzut Barbieri
---------------------------------------
Engenharia de Computacao 2001 - UNICAMP
GPSL - Grupo Pro Software Livre
Cell..: +55 (19) 9165 8010
Jabber: gsb...@ja...
  ICQ#: 17249123
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net

Re: [Libvisual-devel] Take care with arch

[Dennis S. <sy...@yo...>]

stdint, i never knew that one, let me check it out :)

The lv_config.h isn't there, it was an suggestions, but i think stdint
will do.

Thank you!

On Tue, 2004-06-01 at 09:20 -0300, Gustavo Sverzut Barbieri wrote:
> Em Tuesday 01 June 2004 08:09, Dennis Smit escreveu:
> > Gustavo,
> >
> > what do you think about an lv_config.h that gets generated
> > from the config.h.in template ?, i have no experience with this tho.
> 
> Which package? Just downloaded libvisual, ./configure and no lv_config.h, make 
> and still none... locate lv_config.h (my system have libvisual installed) and 
> nothing.
> 
> 
> > How can i set up macros in the template that will generate
> > uint16, int16, (same for 8, 32) for me ?, i'd like to get this fixed
> > in the next release, also someone reported issues with amd64 so
> > hopefully it gets fixed, or atleast partialy fixed by using
> > these types.
> 
> #include <stdint.h>
>