|
From: Pete B. <pb...@gm...> - 2010-10-11 15:17:56
|
On 2010.10.11 15:18, Xiaofan Chen wrote: > I agree that the old patches are not done. Same here. I was planning to recreate them, against the new official, once we're through with the new 8. > Patch 5: xusb example. > http://marc.info/?l=libusb-devel&m=128102886719683&w=2 Refused by Daniel, as per one of his previous e-mails one week ago. Of course I think that's a short-sighted decision, when xusb has already proven helpful when trying to troubleshoot issues with our users, but what are you gonna do? > Patch 6: added .gittarributes > http://marc.info/?l=libusb-devel&m=128103042522279&w=2 This one could probably be applied as is, but I'd rather see it part of a new batch that deals with core. If maintainers want to go through with it right now, that'd be grand. > Patch 7: MS/DDK project files > http://marc.info/?l=libusb-devel&m=128103057922488&w=2 I think the new "consensus" is that the project files should go to the msvc directory. I was planning to work on that once the current are generated. > Patch 8: added libusb-1.0.rc generated > http://marc.info/?l=libusb-devel&m=128103071622760&w=2 Might depend on what we do with version (libusb_version.h, not the rejected libusb_getversion() API call). Personally, I see using a separate libusb_version.h (and .h.in) and referencing it from the .rc as a better approach than going through an .rc.in. Besides, that's more or less what libusb-win32 is doing as well. In that case, the .rc patch needs to be redone. Regards, /Pete |