|
From: David H. <dh...@op...> - 2026-01-18 19:03:16
|
I’m sorry I didn’t see this proposal earlier. My bad. What’s the justification for putting xdr_fixedstring() in libtirpc rather than in your application? Thanks, Dave From: Yair Lenga <yai...@gm...> Sent: Saturday, January 17, 2026 11:31 AM To: Steve Dickson <st...@re...> Cc: Thorsten Kukuk <ku...@su...>; lib...@li... Subject: [EXTERNAL] - Re: [Libtirpc-devel] Proposed enhancement to libtiroc CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. If you feel that the email is suspicious, please report it using PhishAlarm. Steve, It's been a long time since my proposal - but I'm still interested in this improvement. We are being forced to update our system, including alignment with tirpc. I've pulled the code from git://git.linux-nfs.org/projects/steved/libtirpc.git<https://urldefense.com/v3/__http:/git.linux-nfs.org/projects/steved/libtirpc.git__;!!Obbck6kTJA!fNstzzAIWziPmmZTVITCae__iNLT77ZVJT0x8-KMXixElWPiDEw1wv05jUj0W4xfjuX6wqtZHQoxdK_FHzoU$> But I'm not exactly sure how to build. Following from autgen.sh - I've installed automake, libtool, and I opted out from gssapi (--disable-gssapi) - got the library to work. Anything else I'm missing ? For the commit - do you want me to commit a feature branch - add PR, or just a patch file. Not sure if anything changed since 2022. Regards, Yair On Fri, Aug 5, 2022 at 6:35 PM Steve Dickson <st...@re...<mailto:st...@re...>> wrote: On 8/4/22 4:01 AM, Thorsten Kukuk via Libtirpc-devel wrote: > > Hi, > > On Sun, Jul 17, Steve Dickson wrote: > >> Hey! >> >> On 7/17/22 12:33 AM, Yair Lenga wrote: > >>> It will be implemented by new xdr function: >>> >>> bool_t >>> xdr_fuxedstring(xdrs, sp, maxsize) XDR *xdrs; char *sp; u_int maxsize; >>> >>> Note that when deserializing, EVERY character beyond the length will be >>> set to null to result in consistent behavior. >>> >>> Implementation is about 50 lines of addition code to rpcgen, and 30 >>> lines of code to the xdr code (above function). >>> >>> Looking for feedback. >>> >> A couple thoughts... One, is there a man page? >> Secondly if we add this function does the SONAME >> need to be bumped? > > If you add a function, you need to assign a new symbol version to it, > but you don't need to bump the SONAME. > You only need to bump the SONAME, if you change a function interface > in an incompatible way or if you remove a function. Thank you for that clarification! Yair, please feel free to post the needed patches. steved. |