Re: [Libtirpc-devel] [PATCH] Avoid multiple-definiton with gcc -fno-common

[Steve D. <St...@Re...>]

On 1/19/20 5:04 PM, Mike Gilbert wrote:
> GCC 10 enables -fno-common by default.
> 
> Bug: https://bugs.gentoo.org/705896
Committed... even without a Signed-off-by line ;-) (tag: libtirpc-1-2-6-rc2)

steved.
> ---
>  src/rpc_com.h | 3 +--
>  src/svc.c     | 3 +++
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/rpc_com.h b/src/rpc_com.h
> index 10bec79..76badef 100644
> --- a/src/rpc_com.h
> +++ b/src/rpc_com.h
> @@ -61,8 +61,7 @@ void __xprt_unregister_unlocked(SVCXPRT *);
>  void __xprt_set_raddr(SVCXPRT *, const struct sockaddr_storage *);
>  
>  
> -SVCXPRT **__svc_xports;
> -int __svc_maxrec;
> +extern int __svc_maxrec;
>  
>  #ifdef __cplusplus
>  }
> diff --git a/src/svc.c b/src/svc.c
> index b59467b..6db164b 100644
> --- a/src/svc.c
> +++ b/src/svc.c
> @@ -57,6 +57,9 @@
>  
>  #define max(a, b) (a > b ? a : b)
>  
> +static SVCXPRT **__svc_xports;
> +int __svc_maxrec;
> +
>  /*
>   * The services list
>   * Each entry represents a set of procedures (an rpc program).
>