Re: [Libtirpc-devel] [PATCH] rpcbind: configure: fix detection of rpcsvc/mount.h

[Steve D. <St...@Re...>]

On 1/17/20 10:34 AM, Mike Gilbert wrote:
> On Fri, Jan 17, 2020 at 10:09 AM Steve Dickson <St...@re...> wrote:
>>
>>
>>
>> On 1/14/20 3:02 PM, Mike Gilbert wrote:
>>> If libtirpc is providing rpc/rpc.h, including rpcsvc/mount.h may fail if
>>> -I/path/to/tirpc is not passed to the compiler.
>>>
>>> Bug: https://bugs.gentoo.org/665222
>>> Signed-off-by: Mike Gilbert <fl...@ge...>
>> Committed... (tag: rpcbind-1_2_5-rc2)
>>
> 
> Thanks.
> 
> I think you're using the wrong tag name though; rpcbind-1.2.5 was
> released on 2018-08-15. Should probably be tagged as a 1.2.6 release
> candidate.
Fixed.... Thanks for point that out!

> 
> Another issue I ran into with glibc not installing rpcsvc headers: I
> had to install a couple other packages to get all the necessary files
> to compile security.c [1].
> 
> On Gentoo Linux:
> 
> net-libs/rpcsvc-proto provides rpcsvc/mount.h and rpcsvc/nfs_proto.h
> sys-fs/quota[rpc] provides rpcsvc/rmount.h.
> net-libs/libnsl provides rpcsvc/yp.h, rpcsvc/yp_clnt.h, and rpcsvc/rppasswd.h
> 
> In the Gentoo ebuild [2], I ended up setting
> ac_cv_header_rpcsvc_mount_h=no to force security.c to define the
> necessary constants itself. Maybe it would make sense to just do that
> unconditionally upstream?
The glibc that Fedora uses (glibc-2.29) does not install those files anymore 
so when we do the the configuration those files are not found

checking rpcsvc/mount.h usability... no
checking rpcsvc/mount.h presence... no
checking for rpcsvc/mount.h... no

which means HAVE_RPCSVC_MOUNT_H is not define in security.c so the inline
#defines are used... 

Its been this way for while... 
commit 9e0c7ac4879bd69d5dba7c81b40142feeb33d666
Author: Bernhard Reutner-Fischer <rep...@gm...>
Date:   Mon Apr 27 08:30:53 2015 -0400

    configure.ac: Check for rpcsvc/mount.h

The bottom line... those headers should not be needed. 

steved.


> 
> [1] http://git.linux-nfs.org/?p=steved/rpcbind.git;a=blob;f=src/security.c;h=c54ce2639c11289729400ff64a4cd2b6e3199378;hb=40ef74c9ce220cfc7cd146d2c8b16121ae4aef89#l25
> [2] https://gitweb.gentoo.org/repo/gentoo.git/commit/net-nds/rpcbind/rpcbind-1.2.5.ebuild?id=800eb4146cfe655ca8962d7fb692bae138bdfeb1
>