Re: [Libtirpc-devel] [PATCH 1/1] Add authdes_seccreate() stub

[Steve D. <St...@Re...>]

On 12/30/19 1:45 PM, Petr Vorel wrote:
> bf8f0b82d added back authdes_create() and authdes_pk_create() interfaces
> also when authdes compiled out. Add also authdes_seccreate().
> 
> Found by LTP rpc-tirpc test, which fails to link:
> 
> /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: /tmp/ccFanCMm.o: in function `main':
>     testcases/network/rpc/rpc-tirpc/tests_pack/rpc_suite/tirpc/tirpc_auth_authdes_seccreate/tirpc_authdes_seccreate.c:55: undefined reference to `authdes_seccreate'
> 
> Fixes: bf8f0b82d ("Add back the authdes interfaces")
> 
> Signed-off-by: Petr Vorel <pv...@su...>
Committed... (tag: libtirpc-1-2-6-rc1) and Thanks! 

steved.
> ---
> Hi,
> 
> it looks to me that authdes_seccreate() is the only one left out from
> public API functions, but please check.
> 
> Adding it to different source file than the actual implementation is not
> optimal, but I don't see a better way (whole auth_des.c is compiled out
> and it's easier to keep it as it is).
> 
> Kind regards,
> Petr
> 
>  src/rpc_soc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/rpc_soc.c b/src/rpc_soc.c
> index ac7d312..fde121d 100644
> --- a/src/rpc_soc.c
> +++ b/src/rpc_soc.c
> @@ -613,6 +613,13 @@ authdes_pk_create(servername, pkey, window, syncaddr, ckey)
>  	des_block *ckey;		/* optional conversation key to use */
>  { return (NULL); }
>  
> +AUTH *
> +authdes_seccreate(const char *servername, const u_int win,
> +	const char *timehost, const des_block *ckey)
> +{
> +	return (NULL);
> +}
> +
>  #endif
>  
>  
>