Menu

#9 Data generate evaluate minus with one child missing a 'minus'?

1.0
closed
None
2017-10-04
2016-11-30
No

Perhaps its just my lack of knowledge regarding the AST nodes, but looking at https://sourceforge.net/p/libsedml/code/HEAD/tree/trunk/libSedML/DataGenerator.cs#l378 it seems to me that there should be a - or perhaps even a -1.0 * for the case when a minus operator has a single child.

Discussion

  • Frank Bergmann

    Frank Bergmann - 2016-11-30

    agreed! ... looking at that code it actually does seem as if someone just copied that line from the AST_PLUS line ... additionally the code does not seem to deal with n-ary plus / times ... definitely a bug that will be fixed.

     
  • Frank Bergmann

    Frank Bergmann - 2016-11-30
    • status: open --> accepted
    • assigned_to: Frank Bergmann
     
  • Frank Bergmann

    Frank Bergmann - 2016-11-30

    A fix has been committed and a new version of the webtools are deployed. thanks!

     
  • Frank Bergmann

    Frank Bergmann - 2017-10-04
    • status: accepted --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB