Re: [libseccomp-discuss] [PATCH 1/2] AArch64 support v7

[Paul M. <pm...@re...>]

On Friday, August 22, 2014 10:53:32 AM AKASHI Takahiro wrote:
> Marcin,
> 
> On 08/22/2014 12:30 AM, Marcin Juszkiewicz wrote:
> > Changelog
> > 
> > v7 - 2014.08.21
> 
> I think that you'd better split your patch [1/2] into smaller chunks of
> patches for better reviewing.

Yes, it could be split up a bit more (see what I did for 64-bit MIPS), but it 
is okay.  Adding a new ABI is always going to be a huge change and it is 
sometimes hard to break it up into a series of smaller atomic changes that 
still accomplish anything meaningful.

> In addition, it might be preferable to put
> aarch64-related code just after arm-related code. The current
> layout/sequence like
>     ...
>     arm
>     mips64
>     mips64n32
>     aarch64
>     ...
> looks to be disordered. We also have some possibilities to add big endian
> support, if necessary, for arm/arm64 in the future.

True, this is probably the right thing to do, but I'm not too hung up on it at 
the moment as it is a trivial thing to change in the future.

> > - rebased on top of git
> > - created new syscall table based on 3.17-rc1 kernel
> > - added more legacy syscalls as __PNR macros
> 
> I'm not sure, but do we really need those annoying definitions?

I've been spending a good chunk of time reviewing/fixing/reworking Marcin's 
patch today/tonight and while most of the patch is pretty close, the syscall 
table has some significant problems.  I'm going to be posting an updated patch 
shortly that you and Marcin can test/review.

-- 
paul moore
security and virtualization @ redhat