Re: [Fwd: [librsync-devel] bug 1110812 - 4Gigbug.patch does not work in Windows]

[Donovan B. <ab...@mi...>]

On Mon, 2006-03-20 at 19:18 +0530, Sekar Vembu wrote:
> Sorry about not using the SF patch tracker. We will learn the right way 
> to send patches in the future. Hopefully these fixes are useful and you 
> can incorporate it with the right approach in the librsync source code.

Thanks... also, it is worth subscribing to the librsync-dev list on
SF... it means I don't have to keep approving your non-subscriber posts.

These fixes are definitely useful and will go in... the only thing yet
to be determined is how and when :-)

> Thanks
> Sekar
> 
> Donovan Baarda wrote:
> 
> >On Mon, 2006-03-20 at 18:18 +0530, Sekar Vembu wrote:
> >  
> >
> >>Hi,
> >>Subsequent to my original email, I think we have fixed the large file 
> >>problem in Windows too. We have made minor modifications to three files. 
> >>We have tested this and it seems to work for us. I am attaching the 
> >>three files with this email.
> >>1. buf.c
> >>2. librsync.h
> >>3.PcBuild\librsync-config.h
> >>
> >>The following are the cvs-diff for those three files. Hope some expert 
> >>will review this and check this in to the librsync CVS. If there is a 
> >>problem with these changes please let me know.
> >>    
> >>
> >
> >Please submit patches at the SF patch tracker...
> >
> >Also, looking at this, I have a feeling this is compiler dependant,
> >rather than just WIN32 dependent. I suspect this stuff should be handled
> >by configure, rather than peppering the code with more #if WIN32 stuff.
> >Note that PCBuild/librsync-config.h should be auto-generated by running
> >configure with a MSC system.
> >
> >In any case, thanks for this... if no one else gets around to it before
> >me, I'll look into it and see what the best approach for this is...
> >
> >  
> >
-- 
Donovan Baarda <ab...@mi...>
http://minkirri.apana.org.au/~abo/